[electrum] remove unused Transaction.is_memory_compact
ClosedPublic
Actions

Authored by PiRK on Sep 7 2023, 14:03.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC5618cd97e00b: [electrum] remove unused Transaction.is_memory_compact

Summary

This is unused since https://github.com/Bitcoin-ABC/ElectrumABC/commit/93f07bc7b162b95ce39ad549b8ca0892ab679ac4
and it is wrong since we updated the default transaction version to 2.

Test Plan

python test_runner.py

grep -r is_memory_compact .

Diff Detail

Repository

rABC Bitcoin ABC

Branch

mem_comp

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24975
Build 49538: Build Diff	electrum-tests
Build 49537: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 7 2023, 14:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 7 2023, 14:03

PiRK requested review of this revision.Sep 7 2023, 14:03

Harbormaster completed remote builds in B24975: Diff 42112.Sep 7 2023, 14:17

bytesofman accepted this revision.Sep 7 2023, 16:24

This revision is now accepted and ready to land.Sep 7 2023, 16:24

Closed by commit rABC5618cd97e00b: [electrum] remove unused Transaction.is_memory_compact (authored by PiRK). · Explain WhySep 8 2023, 06:04

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC5618cd97e00b: [electrum] remove unused Transaction.is_memory_compact.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

transaction.py

11 lines

Diff 42112

View Options

electrum/electrumabc/transaction.py

[electrum] remove unused Transaction.is_memory_compactClosedPublicActions