Page MenuHomePhabricator
Differential D14462

[electrum] remove unnecessary hex conversion when converting int to bytes
ClosedPublic
Actions

Authored by PiRK on Sep 8 2023, 14:31.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC815c446f7847: [electrum] remove unnecessary hex conversion when converting int to bytes
Summary

Python int has a builtin to_bytes method.
Also rename int_to_hex to int_to_le_hex to clarify what it is doing.

Test Plan
python test_runner.py
python -m electrumabc.bitcoin   # run doctest

Diff Detail

Repository
rABC Bitcoin ABC
Branch
deser_tx
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24981
Build 49550: Build Diffelectrum-tests
Build 49549: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 8 2023, 14:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 8 2023, 14:31
PiRK requested review of this revision.Sep 8 2023, 14:31
Harbormaster completed remote builds in B24981: Diff 42123.Sep 8 2023, 14:33
PiRK added a child revision: D14463: [electrum] remove uneccessary hex <--> bytes conversions in bitcoin.py.Sep 11 2023, 07:06
PiRK added a comment.Sep 11 2023, 08:00

Screenshot from 2023-09-11 08-14-46.png (178×790 px, 31 KB)

Fabien accepted this revision.Sep 11 2023, 08:25
This revision is now accepted and ready to land.Sep 11 2023, 08:25
PiRK updated this revision to Diff 42133.Sep 11 2023, 10:53

rebase

Harbormaster completed remote builds in B24991: Diff 42133.Sep 11 2023, 10:55
Closed by commit rABC815c446f7847: [electrum] remove unnecessary hex conversion when converting int to bytes (authored by PiRK). · Explain WhySep 11 2023, 13:36
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC815c446f7847: [electrum] remove unnecessary hex conversion when converting int to bytes.
PiRK mentioned this in D14490: [electrum] fix int to bytes conversion for curve points when gmpy is installed.Sep 15 2023, 07:18
PiRK mentioned this in rABC047007433a28: [electrum] fix int to bytes conversion for curve points when gmpy is installed.Sep 15 2023, 08:12
PiRK added a child revision: D14643: Fix chain tip data race and corrupt rest response.Oct 16 2023, 08:01
PiRK removed a child revision: D14643: Fix chain tip data race and corrupt rest response.Oct 16 2023, 08:02

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
33 lines
8 lines
6 lines
28 lines
electrumabc_plugins/
ledger/
8 lines

Diff 42123

View Options

electrum/electrumabc/bitcoin.py

Loading...
View Options

electrum/electrumabc/blockchain.py

Loading...
View Options

electrum/electrumabc/keystore.py

Loading...
View Options

electrum/electrumabc/transaction.py

Loading...
View Options

electrum/electrumabc_plugins/ledger/ledger.py

Loading...