Paths

Table of Contentst

Differential D14469

[electrum] delete unused code that raises on linux and windows
ClosedPublic
Actions

Authored by PiRK on Sep 12 2023, 07:22.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC33ce042318c6: [electrum] delete unused code that raises on linux and windows

Summary

This code is unused and caused an error when running pytest --doctest-modules electrumabc

Test Plan

pytest --doctest-modules electrumabc

Note that there is still an error in another module, but it no longer fails on qrreaders

Diff Detail

Repository

rABC Bitcoin ABC

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25000
Build 49588: Build Diff	electrum-tests
Build 49587: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 12 2023, 07:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2023, 07:22

PiRK requested review of this revision.Sep 12 2023, 07:22

Harbormaster completed remote builds in B25000: Diff 42149.Sep 12 2023, 07:24

Fabien accepted this revision.Sep 12 2023, 08:26

This revision is now accepted and ready to land.Sep 12 2023, 08:26

Closed by commit rABC33ce042318c6: [electrum] delete unused code that raises on linux and windows (authored by PiRK). · Explain WhySep 12 2023, 09:03

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC33ce042318c6: [electrum] delete unused code that raises on linux and windows.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

qrreaders/

__init__.py

29 lines

osxqrdetect.py

Diff 42149

View Options

electrum/electrumabc/qrreaders/init.py

View Options

electrum/electrumabc/qrreaders/osxqrdetect.py

[electrum] delete unused code that raises on linux and windowsClosedPublicActions