Paths

Table of Contentst

Differential D14470

[electrum] don't return dict in Transaction.serialize()
ClosedPublic
Actions

Authored by PiRK on Sep 12 2023, 12:16.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCf7ca8b696e66: [electrum] don't return dict in Transaction.serialize()

Summary

This dict is only used in one command and 3 tests. It can be constructed where needed, and the tests can be adjusted.

I removed the test for "prevout_n" in the outputs. This was basically just testing that the first element in a list has index 0.

Test Plan

python test_runner.py
./electrum-abc deserialize 010000000149f35e43fefd22d8bb9e4b3ff294c6286154c25712baf6ab77b646e5074d6aed010000005701ff4c53ff0488b21e0000000000000000004f130d773e678a58366711837ec2e33ea601858262f8eaef246a7ebd19909c9a03c3b30e38ca7d797fee1223df1c9827b2a9f3379768f520910260220e0560014600002300feffffffd8e43201000000000118e43201000000001976a914e158fb15c888037fdc40fb9133b4c1c3c688706488ac5fbd0700

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 12 2023, 12:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2023, 12:16

PiRK requested review of this revision.Sep 12 2023, 12:16

Harbormaster completed remote builds in B25002: Diff 42158.Sep 12 2023, 12:17

PiRK added a child revision: D14471: [electrum] make parse_input return a TxInput.Sep 12 2023, 13:06

Fabien accepted this revision.Sep 13 2023, 06:40

This revision is now accepted and ready to land.Sep 13 2023, 06:40

Closed by commit rABCf7ca8b696e66: [electrum] don't return dict in Transaction.serialize() (authored by PiRK). · Explain WhySep 13 2023, 09:14

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCf7ca8b696e66: [electrum] don't return dict in Transaction.serialize().

PiRK mentioned this in D14504: [electrum] fix return type handling of transaction.deserialize in trezor and keepkey plugins.Sep 19 2023, 08:47

PiRK mentioned this in rABC1e19b3437bf7: [electrum] fix return type handling of transaction.deserialize in trezor and….Sep 19 2023, 15:47

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

20 lines

tests/

test_transaction.py

52 lines

33 lines

Diff 42169

electrum/electrumabc/commands.py

Loading...

electrum/electrumabc/tests/test_transaction.py

Loading...

electrum/electrumabc/transaction.py

Loading...