Page MenuHomePhabricator
Differential D14481

[Cashtab] Deprecate parseXecSendValue
ClosedPublic
Actions

Authored by bytesofman on Sep 13 2023, 21:22.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC82bfbd8efb80: [Cashtab] Deprecate parseXecSendValue
Summary

Depends on D14480

Deprecate mostly useless function parseXecSendValue. Preserve its validation in its one call site.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Sep 13 2023, 21:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2023, 21:22
bytesofman requested review of this revision.Sep 13 2023, 21:22
Harbormaster completed remote builds in B25021: Diff 42183.Sep 13 2023, 21:22
bytesofman updated this revision to Diff 42184.Sep 13 2023, 21:22

lint

Harbormaster completed remote builds in B25022: Diff 42184.Sep 13 2023, 21:25
emack requested changes to this revision.Sep 14 2023, 02:21
emack added a subscriber: emack.
emack added inline comments.
cashtab/src/utils/transactions.js
469 ↗(On Diff #42184)

fromSatoshisToXec already returns a BigNumber so there's no need to convert it to string and then back to BigNumber again.

This revision now requires changes to proceed.Sep 14 2023, 02:21
bytesofman updated this revision to Diff 42206.Sep 14 2023, 16:56

Remove double bignumber

bytesofman marked an inline comment as done.Sep 14 2023, 16:57
Harbormaster completed remote builds in B25040: Diff 42206.Sep 14 2023, 17:00
emack accepted this revision.Sep 14 2023, 22:50
This revision is now accepted and ready to land.Sep 14 2023, 22:50
Closed by commit rABC82bfbd8efb80: [Cashtab] Deprecate parseXecSendValue (authored by bytesofman). · Explain WhySep 14 2023, 23:08
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC82bfbd8efb80: [Cashtab] Deprecate parseXecSendValue.

Revision Contents
Changeset List

PathSize
cashtab/
src/
utils/
__tests__/
64 lines
59 lines
24 lines

Diff 42216

View Options

cashtab/src/utils/__tests__/cashMethods.test.js

Loading...
View Options

cashtab/src/utils/cashMethods.js

Loading...
View Options

cashtab/src/utils/transactions.js

Loading...