Page MenuHomePhabricator
Differential D14508

[electrum] check output type in Transaction and fix a callsites that still passes a regular tuple
ClosedPublic
Actions

Authored by PiRK on Sep 20 2023, 08:12.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd51fd7394adc: [electrum] check output type in Transaction and fix a callsites that still…
Summary

As of D14448, the transaction size estimation requires outputs to be a TxOutput. As of D14502, the tx serializaation also requires a TxOuput.
Enforce this with assertions in the various output setters in Transaction, add typehints to functions that call these setters.

Fix a callsite in the fusion plugin that was still passing a regular tuple.

Test Plan

python test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 20 2023, 08:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 20 2023, 08:12
PiRK requested review of this revision.Sep 20 2023, 08:12
Harbormaster completed remote builds in B25090: Diff 42284.Sep 20 2023, 08:26
Fabien added a subscriber: Fabien.Sep 20 2023, 09:37
Fabien added inline comments.
electrum/electrumabc/transaction.py
1154 ↗(On Diff #42284)

is that really needed since you have the type hints ?

Fabien accepted this revision.Sep 20 2023, 09:41
Fabien added inline comments.
electrum/electrumabc/transaction.py
1154 ↗(On Diff #42284)

That's a linter job that's not enabled on this code yet (mypy)

This revision is now accepted and ready to land.Sep 20 2023, 09:41
PiRK updated this revision to Diff 42297.Sep 20 2023, 15:33

rebase

Harbormaster completed remote builds in B25100: Diff 42297.Sep 20 2023, 15:46
Closed by commit rABCd51fd7394adc: [electrum] check output type in Transaction and fix a callsites that still… (authored by PiRK). · Explain WhySep 20 2023, 15:57
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCd51fd7394adc: [electrum] check output type in Transaction and fix a callsites that still….

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
2 lines
2 lines
40 lines
9 lines
electrumabc_plugins/
fusion/
10 lines
hw_wallet/
2 lines

Diff 42298

View Options

electrum/electrumabc/coinchooser.py

Loading...
View Options

electrum/electrumabc/paymentrequest.py

Loading...
View Options

electrum/electrumabc/transaction.py

Loading...
View Options

electrum/electrumabc/wallet.py

Loading...
View Options

electrum/electrumabc_plugins/fusion/util.py

Loading...
View Options

electrum/electrumabc_plugins/hw_wallet/plugin.py

Loading...