Page MenuHomePhabricator
Differential D14502

[electrum] move Transaction.serialize_output() to TxOutput.serialize()
ClosedPublic
Actions

Authored by PiRK on Sep 19 2023, 06:55.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCfd5a1fca9ffb: [electrum] move Transaction.serialize_output() to TxOutput.serialize()
Summary

Remove Transaction.serialize_output and inline Transaction.pay_script where it is needed.

Depends on D14501

Test Plan

python test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 19 2023, 06:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 19 2023, 06:55
PiRK requested review of this revision.Sep 19 2023, 06:55
Harbormaster completed remote builds in B25070: Diff 42256.Sep 19 2023, 06:56
PiRK added a child revision: D14503: [electrum] convert Transaction.update_signatures to take bytes.Sep 19 2023, 06:58
Fabien accepted this revision.Sep 19 2023, 07:34
This revision is now accepted and ready to land.Sep 19 2023, 07:34
PiRK added a child revision: D14504: [electrum] fix return type handling of transaction.deserialize in trezor and keepkey plugins.Sep 19 2023, 08:47
Closed by commit rABCfd5a1fca9ffb: [electrum] move Transaction.serialize_output() to TxOutput.serialize() (authored by PiRK). · Explain WhySep 19 2023, 10:50
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCfd5a1fca9ffb: [electrum] move Transaction.serialize_output() to TxOutput.serialize().
PiRK mentioned this in D14508: [electrum] check output type in Transaction and fix a callsites that still passes a regular tuple.Sep 20 2023, 08:12
PiRK mentioned this in rABCd51fd7394adc: [electrum] check output type in Transaction and fix a callsites that still….Sep 20 2023, 15:57

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
6 lines
25 lines
electrumabc_plugins/
ledger/
2 lines
satochip/
2 lines
scripts/
4 lines

Diff 42270

View Options

electrum/electrumabc/paymentrequest.py

Loading...
View Options

electrum/electrumabc/transaction.py

Loading...
View Options

electrum/electrumabc_plugins/ledger/ledger.py

Loading...
View Options

electrum/electrumabc_plugins/satochip/satochip.py

Loading...
View Options

electrum/scripts/bip70

Loading...