Page MenuHomePhabricator
Differential D14513

[Cashtab] Deprecate unused function
ClosedPublic
Actions

Authored by bytesofman on Sep 20 2023, 19:25.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC5c292c35cff0: [Cashtab] Deprecate unused function
Summary

T2679

This function is not doing anything. A <div> doesn't have an "onCopy" handler.

Test Plan

npm test

npm start and copying address works as normal

Diff Detail

Repository
rABC Bitcoin ABC
Branch
deprecate-oncopy
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25108
Build 49804: Build Diffcashtab-tests
Build 49803: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sep 20 2023, 19:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 20 2023, 19:25
bytesofman requested review of this revision.Sep 20 2023, 19:25
Harbormaster completed remote builds in B25107: Diff 42306.Sep 20 2023, 19:28
teamcity added a comment.Sep 20 2023, 19:28
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests:  Wallet without BCH balance ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet without BCH balance 1`

- Snapshot  - 1
+ Received  + 0

@@ -63,11 +63,10 @@
    >
      <div
        onClick={[Function]}
      >
        <div
-         onCopy={[Function]}
          style={
            Object {
              "display": "inline-block",
              "position": "relative",
              "width": "100%",
    at Object.<anonymous> (/work/cashtab/src/components/Receive/__tests__/Receive.test.js:44:18)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Wallet with BCH balances ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances 1`

- Snapshot  - 1
+ Received  + 0

@@ -63,11 +63,10 @@
    >
      <div
        onClick={[Function]}
      >
        <div
-         onCopy={[Function]}
          style={
            Object {
              "display": "inline-block",
              "position": "relative",
              "width": "100%",
    at Object.<anonymous> (/work/cashtab/src/components/Receive/__tests__/Receive.test.js:58:18)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Wallet with BCH balances and tokens ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens 1`

- Snapshot  - 1
+ Received  + 0

@@ -63,11 +63,10 @@
    >
      <div
        onClick={[Function]}
      >
        <div
-         onCopy={[Function]}
          style={
            Object {
              "display": "inline-block",
              "position": "relative",
              "width": "100%",
    at Object.<anonymous> (/work/cashtab/src/components/Receive/__tests__/Receive.test.js:72:18)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Wallet with BCH balances and tokens and state field ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens and state field 1`

- Snapshot  - 1
+ Received  + 0

@@ -68,11 +68,10 @@
    >
      <div
        onClick={[Function]}
      >
        <div
-         onCopy={[Function]}
          style={
            Object {
              "display": "inline-block",
              "position": "relative",
              "width": "100%",
    at Object.<anonymous> (/work/cashtab/src/components/Receive/__tests__/Receive.test.js:88:18)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)

Each failure log is accessible here:
CashTab Unit Tests: Wallet without BCH balance
CashTab Unit Tests: Wallet with BCH balances
CashTab Unit Tests: Wallet with BCH balances and tokens
CashTab Unit Tests: Wallet with BCH balances and tokens and state field

bytesofman updated this revision to Diff 42307.Sep 20 2023, 19:52

Update snapshot

Harbormaster completed remote builds in B25108: Diff 42307.Sep 20 2023, 19:55
PiRK accepted this revision.Sep 21 2023, 06:27
This revision is now accepted and ready to land.Sep 21 2023, 06:27
Closed by commit rABC5c292c35cff0: [Cashtab] Deprecate unused function (authored by bytesofman). · Explain WhySep 21 2023, 12:15
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC5c292c35cff0: [Cashtab] Deprecate unused function.

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Common/
18 lines
Receive/
__tests__/
__snapshots__/
6 lines

Diff 42307

View Options

cashtab/src/components/Common/QRCode.js

Loading...
View Options

cashtab/src/components/Receive/__tests__/__snapshots__/Receive.test.js.snap

Loading...