[chronik] Add support for HTTPS connection to the test framework python client
ClosedPublic
Actions

Authored by Fabien on Sep 21 2023, 11:36.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC6aa3bbb32394: [chronik] Add support for HTTPS connection to the test framework python client

Summary

This is not used in the tests but has proven to be useful when writing scripts outside of the test framework.

Test Plan

With Chronik:

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 21 2023, 11:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 21 2023, 11:36

Fabien requested review of this revision.Sep 21 2023, 11:36

Harbormaster completed remote builds in B25113: Diff 42312.Sep 21 2023, 11:54

potential nit: https is set to False by default in the init, but the way the if/else connection and websocket url definition gates are ordered it would seem https is the expected condition.

This revision is now accepted and ready to land.Sep 21 2023, 13:00

In D14515#326029, @bytesofman wrote:

potential nit: https is set to False by default in the init, but the way the if/else connection and websocket url definition gates are ordered it would seem https is the expected condition.

I just wanted to use the shorter version, doing the opposite would require if not self.https which is 4 chars more. I'm that lazy.

Closed by commit rABC6aa3bbb32394: [chronik] Add support for HTTPS connection to the test framework python client (authored by Fabien). · Explain WhySep 21 2023, 13:45

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC6aa3bbb32394: [chronik] Add support for HTTPS connection to the test framework python client.