[apps and Cashtab] Implement monorepo chronik mock and deprecate repo-specific implementations
ClosedPublic
Actions

Authored by bytesofman on Sep 21 2023, 12:31.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC1ed302b86f1e: [apps and Cashtab] Implement monorepo chronik mock and deprecate repo-specific…

Summary

Mocked chronik client was created initially in alias-server to support testing there. Later it was ported to other repos that needed it.

Plan is to get it into chronik-client. For now, though, it should at least live in only one place, so that it isn't maintained many times in the same monorepo.

Implementing.

Test Plan

npm test in apps/ecash-herald, apps/alias-server, and cashtab

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Sep 21 2023, 12:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 21 2023, 12:31

bytesofman requested review of this revision.Sep 21 2023, 12:31

Harbormaster completed remote builds in B25116: Diff 42318.Sep 21 2023, 12:50

I'm not sure it needs to live in chronik-client. Delivering a mock as part of a library is mostly consuming storage for no added value from the lib users point of view. Also chronik-client doesn't need the mock.

This revision is now accepted and ready to land.Sep 21 2023, 14:06

Closed by commit rABC1ed302b86f1e: [apps and Cashtab] Implement monorepo chronik mock and deprecate repo-specific… (authored by bytesofman). · Explain WhySep 21 2023, 14:08

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC1ed302b86f1e: [apps and Cashtab] Implement monorepo chronik mock and deprecate repo-specific….