Page MenuHomePhabricator

[electrum] fix OutPoint.__str__
ClosedPublic

Authored by PiRK on Sep 21 2023, 15:38.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC75b8d794395d: [electrum] fix OutPoint.__str__
Summary

I added an extra parenthesis when implementing this function in D14432, I started breaking things in a limited way D14472 by using str(txin.outpoint) (reading tx from file or from a pasted string), and it started getting really bad in D14520 when additional usage of str(txin.outpoint) in critical wallet code corrupted my test wallet file.

String outpoints are used in the wallet to locate inputs.

Test Plan

python test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable