Page MenuHomePhabricator

[Cashtab] Load settings page with saved wallets collapse open
ClosedPublic

Authored by bytesofman on Sep 24 2023, 22:48.

Details

Summary

Request from cain. This probably is an improvement. Most of the time I go to settings page it is to change the wallet.

Other potential improvements: saved wallets collapse should probably appear higher on the settings screen. Better still, you should be able to change thoe active wallet from any screen, or at least the 'receive' and 'home' screens.

Test Plan

npm test, judgment if this is improvement, if not, if more should be done

Diff Detail

Repository
rABC Bitcoin ABC
Branch
wallets-open-default-settings-page
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25147
Build 49882: Build Diffcashtab-tests
Build 49881: arc lint + arc unit

Event Timeline

emack added a subscriber: emack.

image.png (264×504 px, 18 KB)

Default open works fine. Since this highlighted area is common to all main screens we can potentially turn this into a dropdown populated with the saved wallets.

This revision is now accepted and ready to land.Sep 25 2023, 00:52