Page MenuHomePhabricator
Differential D14530

[electrum] rename tx_from_str to rawtx_from_str
ClosedPublic
Actions

Authored by PiRK on Sep 25 2023, 06:42.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC8026628e786b: [electrum] rename tx_from_str to rawtx_from_str
Summary

Make it clear that the function does not return a Transaction object.

Improve documentation and clean up the code. No need to catch Exception, only ValueError makes sense if the string is not hex.
Depends on D14524

Test Plan
./electrum-abc deserialize 02000000012367ad0da9fb8f8a7e574d55d4eb2dd0fd8ebd58b1c21cfddb9fe5426369082a000000006441761c8b702e06fcb8656cb205454f22efff174e3ae9552c1ee83f7d64e3b0d29fa466c48a82597713fd7a3c03e324855349a76660fa26dfec4922c51ea0f51cb6412102a42cd220e6099d5d678066b81813ae4fdd14b290479962ae5c0af1448113bcb4feffff

./electrum-abc deserialize spam

In the application, menu Tools > Load Transaction > From Text

To test the JSON format, go to the Send tab, prepare a transaction, click Preview then Save. Then menu Tools > Load Transaction > From File

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 25 2023, 06:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 25 2023, 06:42
PiRK requested review of this revision.Sep 25 2023, 06:42
Harbormaster completed remote builds in B25149: Diff 42361.Sep 25 2023, 06:44
PiRK updated this revision to Diff 42366.Sep 25 2023, 07:16

rebase

Harbormaster completed remote builds in B25153: Diff 42366.Sep 25 2023, 07:18
PiRK edited the summary of this revision. (Show Details)Sep 25 2023, 07:18
PiRK edited the test plan for this revision. (Show Details)
Fabien accepted this revision.Sep 25 2023, 09:02
This revision is now accepted and ready to land.Sep 25 2023, 09:02
Closed by commit rABC8026628e786b: [electrum] rename tx_from_str to rawtx_from_str (authored by PiRK). · Explain WhySep 25 2023, 12:16
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC8026628e786b: [electrum] rename tx_from_str to rawtx_from_str.
PiRK mentioned this in D14780: [electrum] fix address resolving and building transaction from hex in RPC commands.Nov 13 2023, 15:47
PiRK mentioned this in rABCec6259228561: [electrum] fix address resolving and building transaction from hex in RPC….Nov 14 2023, 10:43

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
4 lines
18 lines
electrumabc_gui/
qt/
6 lines

Diff 42371

View Options

electrum/electrumabc/commands.py

Loading...
View Options

electrum/electrumabc/transaction.py

Loading...
View Options

electrum/electrumabc_gui/qt/main_window.py

Loading...