Page MenuHomePhabricator

[electrum] fix error dialogs in main_window
ClosedPublic

Authored by PiRK on Sep 25 2023, 07:09.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC692e0c46d453: [electrum] fix error dialogs in main_window
Summary

util.is_verbose does not exist since https://github.com/Bitcoin-ABC/ElectrumABC/commit/fdefdbc8f5deb70b92efa2341bb83910d94c7f3c
As a result, the user sees a python traceback instead of a helpful error dialog.

In change_password_dilaog, an except branch was unreachabe, merge it with the previous branch (this has been broken since 2016 https://github.com/spesmilo/electrum/commit/c6a46df15887736969c7a7a448c76f9a9ed0c21e)

Test Plan

In the application, load a transaction from text, type a malformed transaction (non-hex, non-JSON), check that the error dialog prints "Electrum ABC was unable to parse your transaction". Check that the error stack is now only displayed in the terminal when running in verbose mode -v.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_is_verbose
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25150
Build 49888: Build Diffelectrum-tests
Build 49887: arc lint + arc unit

Event Timeline

PiRK requested review of this revision.Sep 25 2023, 07:09
Fabien added a subscriber: Fabien.

Nice case of silently breaking stuff

This revision is now accepted and ready to land.Sep 25 2023, 09:04
This revision was automatically updated to reflect the committed changes.