Page MenuHomePhabricator
Differential D14545

Bump replay protection to May 15th 2024
ClosedPublic
Actions

Authored by Mengerian on Sep 26 2023, 18:48.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7695e77bf559: Bump replay protection to May 15th 2024
Summary

Similar to D13139

Test Plan

Carefully check timestamp
ninja check-extended
Run IBD

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Mengerian created this revision.Sep 26 2023, 18:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 26 2023, 18:48
Mengerian requested review of this revision.Sep 26 2023, 18:48
Mengerian added a comment.Sep 26 2023, 18:49

Will not land this until all the upgrade items are completed

Mengerian added a comment.Sep 26 2023, 18:50

@bot build-ibd

teamcity awarded a token.Sep 26 2023, 18:51
Harbormaster completed remote builds in B25174: Diff 42405.Sep 26 2023, 19:07
Fabien accepted this revision.Sep 27 2023, 08:46
This revision is now accepted and ready to land.Sep 27 2023, 08:46
Mengerian updated this revision to Diff 42602.Oct 9 2023, 17:10

rebase

Harbormaster completed remote builds in B25305: Diff 42602.Oct 9 2023, 17:43
Mengerian updated this revision to Diff 42607.Oct 9 2023, 20:39

rebase

Harbormaster completed remote builds in B25306: Diff 42607.Oct 9 2023, 21:17
teamcity added a comment.Oct 9 2023, 21:17
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

wallet_groups.py                           | ✓ Passed  | 13 s
wallet_hd.py                               | ✓ Passed  | 5 s
wallet_hd.py --descriptors                 | ✓ Passed  | 5 s
wallet_import_rescan.py                    | ✓ Passed  | 6 s
wallet_import_with_label.py                | ✓ Passed  | 1 s
wallet_importdescriptors.py                | ✓ Passed  | 3 s
wallet_importmulti.py                      | ✓ Passed  | 2 s
wallet_importprunedfunds.py                | ✓ Passed  | 2 s
wallet_importprunedfunds.py --descriptors  | ✓ Passed  | 1 s
wallet_keypool.py                          | ✓ Passed  | 3 s
wallet_keypool_topup.py                    | ✓ Passed  | 2 s
wallet_keypool_topup.py --descriptors      | ✓ Passed  | 3 s
wallet_labels.py                           | ✓ Passed  | 1 s
wallet_labels.py --descriptors             | ✓ Passed  | 1 s
wallet_listreceivedby.py                   | ✓ Passed  | 5 s
wallet_listsinceblock.py                   | ✓ Passed  | 5 s
wallet_listsinceblock.py --descriptors     | ✓ Passed  | 2 s
wallet_listtransactions.py                 | ✓ Passed  | 4 s
wallet_listtransactions.py --descriptors   | ✓ Passed  | 3 s
wallet_multiwallet.py                      | ✓ Passed  | 41 s
wallet_multiwallet.py --usecli             | ✓ Passed  | 9 s
wallet_reorgsrestore.py                    | ✓ Passed  | 3 s
wallet_resendwallettransactions.py         | ✓ Passed  | 12 s
wallet_send.py                             | ✓ Passed  | 9 s
wallet_startup.py                          | ✓ Passed  | 2 s
wallet_timelock.py                         | ✓ Passed  | 1 s
wallet_txn_clone.py                        | ✓ Passed  | 1 s
wallet_txn_clone.py --mineblock            | ✓ Passed  | 2 s
wallet_txn_doublespend.py                  | ✓ Passed  | 1 s
wallet_txn_doublespend.py --mineblock      | ✓ Passed  | 2 s
wallet_watchonly.py                        | ✓ Passed  | 1 s
wallet_watchonly.py --usecli               | ✓ Passed  | 1 s
chronik_avalanche.py                       | ○ Skipped | 0 s
chronik_block.py                           | ○ Skipped | 0 s
chronik_block_info.py                      | ○ Skipped | 0 s
chronik_block_txs.py                       | ○ Skipped | 0 s
chronik_blockchain_info.py                 | ○ Skipped | 0 s
chronik_blocks.py                          | ○ Skipped | 0 s
chronik_disallow_prune.py                  | ○ Skipped | 0 s
chronik_pause.py                           | ○ Skipped | 0 s
chronik_raw_tx.py                          | ○ Skipped | 0 s
chronik_resync.py                          | ○ Skipped | 0 s
chronik_script_confirmed_txs.py            | ○ Skipped | 0 s
chronik_script_history.py                  | ○ Skipped | 0 s
chronik_script_unconfirmed_txs.py          | ○ Skipped | 0 s
chronik_script_utxos.py                    | ○ Skipped | 0 s
chronik_serve.py                           | ○ Skipped | 0 s
chronik_spent_by.py                        | ○ Skipped | 0 s
chronik_tx.py                              | ○ Skipped | 0 s
chronik_ws.py                              | ○ Skipped | 0 s
chronik_ws_script.py                       | ○ Skipped | 0 s
interface_usdt_net.py                      | ○ Skipped | 0 s
interface_usdt_utxocache.py                | ○ Skipped | 0 s
interface_usdt_validation.py               | ○ Skipped | 0 s

ALL                                        | ✓ Passed  | 1244 s (accumulated) 
Runtime: 256 s

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
PiRK added a subscriber: PiRK.Oct 10 2023, 04:11

Unrelated test failure, just a timeout in the test that verifies Electrum ABC can parse SSL certificates.
If that test causes more intermittent failures, I'll remove it. I don't like having tests that rely on the internet.

Mengerian added a comment.Oct 10 2023, 14:39

@bot build-diff

teamcity updated a token.Oct 10 2023, 14:39
teamcity added a comment.Oct 10 2023, 14:55
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

wallet_groups.py                           | ✓ Passed  | 12 s
wallet_hd.py                               | ✓ Passed  | 7 s
wallet_hd.py --descriptors                 | ✓ Passed  | 5 s
wallet_import_rescan.py                    | ✓ Passed  | 6 s
wallet_import_with_label.py                | ✓ Passed  | 1 s
wallet_importdescriptors.py                | ✓ Passed  | 4 s
wallet_importmulti.py                      | ✓ Passed  | 3 s
wallet_importprunedfunds.py                | ✓ Passed  | 2 s
wallet_importprunedfunds.py --descriptors  | ✓ Passed  | 1 s
wallet_keypool.py                          | ✓ Passed  | 3 s
wallet_keypool_topup.py                    | ✓ Passed  | 4 s
wallet_keypool_topup.py --descriptors      | ✓ Passed  | 3 s
wallet_labels.py                           | ✓ Passed  | 1 s
wallet_labels.py --descriptors             | ✓ Passed  | 1 s
wallet_listreceivedby.py                   | ✓ Passed  | 6 s
wallet_listsinceblock.py                   | ✓ Passed  | 5 s
wallet_listsinceblock.py --descriptors     | ✓ Passed  | 2 s
wallet_listtransactions.py                 | ✓ Passed  | 4 s
wallet_listtransactions.py --descriptors   | ✓ Passed  | 3 s
wallet_multiwallet.py                      | ✓ Passed  | 39 s
wallet_multiwallet.py --usecli             | ✓ Passed  | 9 s
wallet_reorgsrestore.py                    | ✓ Passed  | 4 s
wallet_resendwallettransactions.py         | ✓ Passed  | 3 s
wallet_send.py                             | ✓ Passed  | 8 s
wallet_startup.py                          | ✓ Passed  | 2 s
wallet_timelock.py                         | ✓ Passed  | 1 s
wallet_txn_clone.py                        | ✓ Passed  | 2 s
wallet_txn_clone.py --mineblock            | ✓ Passed  | 2 s
wallet_txn_doublespend.py                  | ✓ Passed  | 1 s
wallet_txn_doublespend.py --mineblock      | ✓ Passed  | 3 s
wallet_watchonly.py                        | ✓ Passed  | 1 s
wallet_watchonly.py --usecli               | ✓ Passed  | 1 s
chronik_avalanche.py                       | ○ Skipped | 0 s
chronik_block.py                           | ○ Skipped | 0 s
chronik_block_info.py                      | ○ Skipped | 0 s
chronik_block_txs.py                       | ○ Skipped | 0 s
chronik_blockchain_info.py                 | ○ Skipped | 0 s
chronik_blocks.py                          | ○ Skipped | 0 s
chronik_disallow_prune.py                  | ○ Skipped | 0 s
chronik_pause.py                           | ○ Skipped | 0 s
chronik_raw_tx.py                          | ○ Skipped | 0 s
chronik_resync.py                          | ○ Skipped | 0 s
chronik_script_confirmed_txs.py            | ○ Skipped | 0 s
chronik_script_history.py                  | ○ Skipped | 0 s
chronik_script_unconfirmed_txs.py          | ○ Skipped | 0 s
chronik_script_utxos.py                    | ○ Skipped | 0 s
chronik_serve.py                           | ○ Skipped | 0 s
chronik_spent_by.py                        | ○ Skipped | 0 s
chronik_tx.py                              | ○ Skipped | 0 s
chronik_ws.py                              | ○ Skipped | 0 s
chronik_ws_script.py                       | ○ Skipped | 0 s
interface_usdt_net.py                      | ○ Skipped | 0 s
interface_usdt_utxocache.py                | ○ Skipped | 0 s
interface_usdt_validation.py               | ○ Skipped | 0 s

ALL                                        | ✓ Passed  | 1257 s (accumulated) 
Runtime: 252 s

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
Mengerian updated this revision to Diff 42617.Oct 10 2023, 15:36

rebase

Harbormaster completed remote builds in B25313: Diff 42617.Oct 10 2023, 15:53
Closed by commit rABC7695e77bf559: Bump replay protection to May 15th 2024 (authored by Mengerian). · Explain WhyOct 10 2023, 16:22
This revision was automatically updated to reflect the committed changes.
Mengerian added a commit: rABC7695e77bf559: Bump replay protection to May 15th 2024.

Revision Contents
Changeset List

PathSize
doc/
2 lines
src/
9 lines
consensus/
2 lines
5 lines

Diff 42620

View Options

doc/release-notes.md

Loading...
View Options

src/chainparams.cpp

Loading...
View Options

src/consensus/params.h

Loading...
View Options

src/validation.cpp

Loading...