[electrum] coinchooser bucket refactoring
ClosedPublic
Actions

Authored by PiRK on Sep 29 2023, 09:55.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC4be2c448f6af: [electrum] coinchooser bucket refactoring

Summary

Clarify the coinchooser code by removing the keys() indirection. Store TxInput objects in the bucket (avoid calling TxInput.from_coin_dict twice.

What is currently preventing CoinChooserBase.make_tx from taking a list of TxInput coins instead of coin dicts is the lack of a height field in TxInput.
I will fix this in a separate diff.

Test Plan

send a transaction

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 29 2023, 09:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 29 2023, 09:55

PiRK requested review of this revision.Sep 29 2023, 09:55

Harbormaster completed remote builds in B25208: Diff 42450.Sep 29 2023, 09:56

PiRK added a child revision: D14561: [electrum] let CoinChooser.make_tx take a list of TxInput.Sep 29 2023, 10:02

Fabien accepted this revision.Sep 29 2023, 16:05

Fabien added a subscriber: Fabien.

Fabien added inline comments.

electrum/electrumabc/coinchooser.py
97 ↗	(On Diff #42450)	could be `self.min_height = min(self.min_height, coin_dict["height"]) if self.min_height is not None else coin_dict["height"]` ?