Paths

Table of Contentst

Differential D14563

[ecash-coinselect] Improve dust error msg
ClosedPublic
Actions

Authored by bytesofman on Sep 29 2023, 16:51.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC7cd9df417870: [ecash-coinselect] Improve dust error msg

Summary

Existing error msg is incorrect as a tx may send exactly 546 satoshis

Test Plan

Review new error msg for quality, npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Sep 29 2023, 16:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 29 2023, 16:51

bytesofman requested review of this revision.Sep 29 2023, 16:51

Note: This is the kind of minor change that I don't think requires a version bump, as we will be adding more improvements to this lib. So, this will get rolled into the next update.

I'm looking at automated CI publication of npm libs.

Harbormaster completed remote builds in B25214: Diff 42462.Sep 29 2023, 17:08

Fabien accepted this revision.Sep 29 2023, 17:49

This revision is now accepted and ready to land.Sep 29 2023, 17:49

Closed by commit rABC7cd9df417870: [ecash-coinselect] Improve dust error msg (authored by bytesofman). · Explain WhySep 29 2023, 17:58

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC7cd9df417870: [ecash-coinselect] Improve dust error msg.

Revision Contents
Changeset List

Path

Size

modules/

ecash-coinselect/

src/

coinSelect.js

2 lines

test/

coinSelect.test.js

2 lines

Diff 42463

View Options

modules/ecash-coinselect/src/coinSelect.js