Page MenuHomePhabricator
Differential D14563

[ecash-coinselect] Improve dust error msg
ClosedPublic
Actions

Authored by bytesofman on Sep 29 2023, 16:51.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7cd9df417870: [ecash-coinselect] Improve dust error msg
Summary

Existing error msg is incorrect as a tx may send exactly 546 satoshis

Test Plan

Review new error msg for quality, npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
better-coinselect-error-msg
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25214
Build 50016: Build Diffecash-coinselect
Build 50015: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sep 29 2023, 16:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 29 2023, 16:51
bytesofman requested review of this revision.Sep 29 2023, 16:51
bytesofman added a comment.Sep 29 2023, 16:52

Note: This is the kind of minor change that I don't think requires a version bump, as we will be adding more improvements to this lib. So, this will get rolled into the next update.

I'm looking at automated CI publication of npm libs.

Harbormaster completed remote builds in B25214: Diff 42462.Sep 29 2023, 17:08
Fabien accepted this revision.Sep 29 2023, 17:49
This revision is now accepted and ready to land.Sep 29 2023, 17:49
Closed by commit rABC7cd9df417870: [ecash-coinselect] Improve dust error msg (authored by bytesofman). · Explain WhySep 29 2023, 17:58
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC7cd9df417870: [ecash-coinselect] Improve dust error msg.

Revision Contents
Changeset List

PathSize
modules/
ecash-coinselect/
src/
2 lines
test/
2 lines

Diff 42462

View Options

modules/ecash-coinselect/src/coinSelect.js

Loading...
View Options

modules/ecash-coinselect/test/coinSelect.test.js

Loading...