Paths

Table of Contentst

Differential D14574

[Cashtab] Refactor new tx function to accept targetOutputs
ClosedPublic
Actions

Authored by bytesofman on Oct 2 2023, 16:05.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC6fc0fc1db8ad: [Cashtab] Refactor new tx function to accept targetOutputs

Summary

Have new sendXec function accept targetOutputs instead of creating it. This will allow extended support of different types of XEC txs without overloading this sendXec function.

While the function is renamed to be more general, it is not yet unit tested for other cases. These will be added before the function is implemented in the app.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Oct 2 2023, 16:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2023, 16:05

bytesofman requested review of this revision.Oct 2 2023, 16:05

bytesofman added a child revision: D14575: [Cashtab] Replace obsolete log statement in unit test.Oct 2 2023, 16:07

Harbormaster completed remote builds in B25228: Diff 42488.Oct 2 2023, 16:12

PiRK accepted this revision.Oct 3 2023, 04:35

This revision is now accepted and ready to land.Oct 3 2023, 04:35

Closed by commit rABC6fc0fc1db8ad: [Cashtab] Refactor new tx function to accept targetOutputs (authored by bytesofman). · Explain WhyOct 3 2023, 17:58

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC6fc0fc1db8ad: [Cashtab] Refactor new tx function to accept targetOutputs.

Revision Contents
Changeset List

Path

Size

cashtab/

src/

transactions/

__tests__/

42 lines

fixtures/

123 lines

14 lines

Diff 42515

cashtab/src/transactions/tests/index.test.js

Loading...

cashtab/src/transactions/fixtures/vectors.js

Loading...

cashtab/src/transactions/index.js

Loading...