Page MenuHomePhabricator

[Cashtab] Remove encrypted msg sending
ClosedPublic

Authored by bytesofman on Oct 2 2023, 21:25.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC1c6a6e804070: [Cashtab] Remove encrypted msg sending
Summary

Remove feature for sending encrypted msgs. Deprecation cycle has been short, but we have only seen a few of these msgs since August, last one on Oct 3.

Initial idea here was to show it can be done when the main focus of Cashtab development was trying out new features and iterating toward unique web wallet use cases. The feature is high complexity and not widely used. Supporting it through other Cashtab upgrades is not worth it.

Ultimately, if you want a message to be secret -- the blockchain is not the place for it.

This diff removes the ability to send encrypted msg op_return txs in Cashtab. However, functions used to parse such msgs in tx history, and functions used to create the actual transactions, are left unchanged for now. This is because the functions that deal with encrypted msg sending are already-overloaded tx creation functions that will be replaced by new functions. It's not worth removing this complexity from these functions as they will be rewritten and dropped in other diffs.

Test Plan

npm test

Diff Detail

Event Timeline

Fabien requested changes to this revision.Oct 3 2023, 06:48
Fabien added a subscriber: Fabien.

This needs to go through a proper deprecation cycle:

  1. Announce that it is going to be deprecated. The feature can be hidden behind a config flag or something similar if needed.
  2. Wait for long enough
  3. Remove it
This revision now requires changes to proceed.Oct 3 2023, 06:48

Rebase, remove deprecation notice

cashtab/src/components/Send/Send.js
189

unrelated change, handled in D14716

bytesofman retitled this revision from [Cashtab] Deprecate encrypted msg sending to [Cashtab] Remove encrypted msg sending.Nov 2 2023, 13:36
bytesofman edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Nov 2 2023, 13:37
This revision was automatically updated to reflect the committed changes.