Page MenuHomePhabricator
Differential D14583

streams: Add AutoFile without ser-type and ser-version
ClosedPublic
Actions

Authored by PiRK on Oct 3 2023, 12:31.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCa132cedbc755: streams: Add AutoFile without ser-type and ser-version
Summary

The basic idea is that serialization type should not be initialized when it is not needed. Same for the serialization version.

So do this here for AutoFile. CAutoFile remains in places where it is not yet possible.

The moved parts can be reviewed with "--color-moved=dimmed-zebra".
The one-char changes can be reviewed with "--word-diff-regex=.".

This is a backport of core#25285

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 3 2023, 12:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 3 2023, 12:31
PiRK requested review of this revision.Oct 3 2023, 12:31
teamcity edited the summary of this revision. (Show Details)Oct 3 2023, 12:31
Harbormaster completed remote builds in B25242: Diff 42506.Oct 3 2023, 12:50
bytesofman accepted this revision.Oct 3 2023, 18:33
bytesofman added a subscriber: bytesofman.

green w/ formatting nit

src/validation.h
1115 ↗(On Diff #42506)

remove unrelated line break

This revision is now accepted and ready to land.Oct 3 2023, 18:33
PiRK updated this revision to Diff 42530.Oct 4 2023, 10:34

remove unrelated line break

This revision was landed with ongoing or failed builds.Oct 4 2023, 10:35
Closed by commit rABCa132cedbc755: streams: Add AutoFile without ser-type and ser-version (authored by MacroFake <falke.marco@gmail.com>, committed by PiRK). · Explain Why
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCa132cedbc755: streams: Add AutoFile without ser-type and ser-version.
Harbormaster completed remote builds in B25260: Diff 42530.Oct 4 2023, 10:59

Revision Contents
Changeset List

PathSize
src/
index/
10 lines
2 lines
rpc/
2 lines
4 lines
69 lines
test/
18 lines
fuzz/
4 lines
10 lines
util/
6 lines
10 lines
util/
2 lines
4 lines
4 lines
test/
functional/
2 lines

Diff 42531

View Options

src/index/blockfilterindex.cpp

Loading...
View Options

src/net.cpp

Loading...
View Options

src/rpc/blockchain.h

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/streams.h

Loading...
View Options

src/test/flatfile_tests.cpp

Loading...
View Options

src/test/fuzz/autofile.cpp

Loading...
View Options

src/test/fuzz/util.h

Loading...
View Options

src/test/util/chainstate.h

Loading...
View Options

src/test/validation_chainstatemanager_tests.cpp

Loading...
View Options

src/util/asmap.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/functional/feature_addrman.py

Loading...