Page MenuHomePhabricator

[avalanche] Fix occasional failures in abc_p2p_avalanche_voting
ClosedPublic

Authored by Fabien on Oct 3 2023, 13:34.

Details

Summary

The test for node banning after some unexpected ava response expects no inflight poll/response, which is sometimes not true when running on qemu. Fix by finalizing/invalidating all the items along the test.

Test Plan
./test/functional/test_runner.py abc_p2p_avalanche_voting

Also ran build-linux-aarch64, cd'ed into the build dir and ran:

for i in {1..30}; do
  echo "Trial $i" && QEMU_LD_PREFIX=/usr/aarch64-linux-gnu ./test/functional/test_runner.py abc_p2p_avalanche_voting.py || break;
done

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_avalanche_voting_qemu
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25245
Build 50076: Build Diffbuild-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 50075: arc lint + arc unit