Show an alert msg on the Send screen for planned deprecation of encrypted msg sending
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC6b78116f04b3: [Cashtab] Add deprecation announcement for encrypted msgs
npm test, review screenshot for date and appearance of notice
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- encrypted-msg-deprecation-announcement
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 25249 Build 50084: Build Diff cashtab-tests Build 50083: arc lint + arc unit
Event Timeline
Failed tests logs:
====== CashTab Unit Tests: Wallet without BCH balance ====== Error: expect(received).toMatchSnapshot() Snapshot name: `Wallet without BCH balance 1` - Snapshot - 0 + Received + 42 @@ -579,7 +579,49 @@ </div> </div> </form> </div> </div> + <div + className="ant-alert ant-alert-info ant-alert-with-description" + data-show={true} + role="alert" + style={ + Object { + "marginBottom": "10px", + } + } + > + <span + aria-label="info-circle" + className="anticon anticon-info-circle ant-alert-icon" + role="img" + > + <svg + aria-hidden="true" + data-icon="info-circle" + fill="currentColor" + focusable="false" + height="1em" + viewBox="64 64 896 896" + width="1em" + > + <path + d="M512 64C264.6 64 64 264.6 64 512s200.6 448 448 448 448-200.6 448-448S759.4 64 512 64zm0 820c-205.4 0-372-166.6-372-372s166.6-372 372-372 372 166.6 372 372-166.6 372-372 372z" + /> + <path + d="M464 336a48 48 0 1096 0 48 48 0 10-96 0zm72 112h-48c-4.4 0-8 3.6-8 8v272c0 4.4 3.6 8 8 8h48c4.4 0 8-3.6 8-8V456c0-4.4-3.6-8-8-8z" + /> + </svg> + </span> + <div + className="ant-alert-content" + > + <div + className="ant-alert-description" + > + Encrypted msgs will be deprecated on Oct 17 + </div> + </div> + </div> </div>, ] at Object.<anonymous> (/work/cashtab/src/components/Send/__tests__/Send.test.js:44:18) at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:391:28) at new Promise (<anonymous>) at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:316:10) at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:218:40) at processTicksAndRejections (node:internal/process/task_queues:96:5) at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:155:3) at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:66:9) at run (/work/cashtab/node_modules/jest-circus/build/run.js:25:3) at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21) at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19) at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:389:16) at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:475:34) at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:133:12) ====== CashTab Unit Tests: Wallet with BCH balances ====== Error: expect(received).toMatchSnapshot() Snapshot name: `Wallet with BCH balances 1` - Snapshot - 0 + Received + 42 @@ -579,7 +579,49 @@ </div> </div> </form> </div> </div> + <div + className="ant-alert ant-alert-info ant-alert-with-description" + data-show={true} + role="alert" + style={ + Object { + "marginBottom": "10px", + } + } + > + <span + aria-label="info-circle" + className="anticon anticon-info-circle ant-alert-icon" + role="img" + > + <svg + aria-hidden="true" + data-icon="info-circle" + fill="currentColor" + focusable="false" + height="1em" + viewBox="64 64 896 896" + width="1em" + > + <path + d="M512 64C264.6 64 64 264.6 64 512s200.6 448 448 448 448-200.6 448-448S759.4 64 512 64zm0 820c-205.4 0-372-166.6-372-372s166.6-372 372-372 372 166.6 372 372-166.6 372-372 372z" + /> + <path + d="M464 336a48 48 0 1096 0 48 48 0 10-96 0zm72 112h-48c-4.4 0-8 3.6-8 8v272c0 4.4 3.6 8 8 8h48c4.4 0 8-3.6 8-8V456c0-4.4-3.6-8-8-8z" + /> + </svg> + </span> + <div + className="ant-alert-content" + > + <div + className="ant-alert-description" + > + Encrypted msgs will be deprecated on Oct 17 + </div> + </div> + </div> </div>, ] at Object.<anonymous> (/work/cashtab/src/components/Send/__tests__/Send.test.js:58:18) at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:391:28) at new Promise (<anonymous>) at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:316:10) at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:218:40) at processTicksAndRejections (node:internal/process/task_queues:96:5) at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:155:3) at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:66:9) at run (/work/cashtab/node_modules/jest-circus/build/run.js:25:3) at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21) at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19) at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:389:16) at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:475:34) at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:133:12) ====== CashTab Unit Tests: Wallet with BCH balances and tokens ====== Error: expect(received).toMatchSnapshot() Snapshot name: `Wallet with BCH balances and tokens 1` - Snapshot - 0 + Received + 42 @@ -579,7 +579,49 @@ </div> </div> </form> </div> </div> + <div + className="ant-alert ant-alert-info ant-alert-with-description" + data-show={true} + role="alert" + style={ + Object { + "marginBottom": "10px", + } + } + > + <span + aria-label="info-circle" + className="anticon anticon-info-circle ant-alert-icon" + role="img" + > + <svg + aria-hidden="true" + data-icon="info-circle" + fill="currentColor" + focusable="false" + height="1em" + viewBox="64 64 896 896" + width="1em" + > + <path + d="M512 64C264.6 64 64 264.6 64 512s200.6 448 448 448 448-200.6 448-448S759.4 64 512 64zm0 820c-205.4 0-372-166.6-372-372s166.6-372 372-372 372 166.6 372 372-166.6 372-372 372z" + /> + <path + d="M464 336a48 48 0 1096 0 48 48 0 10-96 0zm72 112h-48c-4.4 0-8 3.6-8 8v272c0 4.4 3.6 8 8 8h48c4.4 0 8-3.6 8-8V456c0-4.4-3.6-8-8-8z" + /> + </svg> + </span> + <div + className="ant-alert-content" + > + <div + className="ant-alert-description" + > + Encrypted msgs will be deprecated on Oct 17 + </div> + </div> + </div> </div>, ] at Object.<anonymous> (/work/cashtab/src/components/Send/__tests__/Send.test.js:72:18) at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:391:28) at new Promise (<anonymous>) at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:316:10) at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:218:40) at processTicksAndRejections (node:internal/process/task_queues:96:5) at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:155:3) at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:66:9) at run (/work/cashtab/node_modules/jest-circus/build/run.js:25:3) at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21) at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19) at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:389:16) at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:475:34) at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:133:12) ====== CashTab Unit Tests: Wallet with BCH balances and tokens and state field ====== Error: expect(received).toMatchSnapshot() Snapshot name: `Wallet with BCH balances and tokens and state field 1` - Snapshot - 0 + Received + 42 @@ -585,7 +585,49 @@ </div> </div> </form> </div> </div> + <div + className="ant-alert ant-alert-info ant-alert-with-description" + data-show={true} + role="alert" + style={ + Object { + "marginBottom": "10px", + } + } + > + <span + aria-label="info-circle" + className="anticon anticon-info-circle ant-alert-icon" + role="img" + > + <svg + aria-hidden="true" + data-icon="info-circle" + fill="currentColor" + focusable="false" + height="1em" + viewBox="64 64 896 896" + width="1em" + > + <path + d="M512 64C264.6 64 64 264.6 64 512s200.6 448 448 448 448-200.6 448-448S759.4 64 512 64zm0 820c-205.4 0-372-166.6-372-372s166.6-372 372-372 372 166.6 372 372-166.6 372-372 372z" + /> + <path + d="M464 336a48 48 0 1096 0 48 48 0 10-96 0zm72 112h-48c-4.4 0-8 3.6-8 8v272c0 4.4 3.6 8 8 8h48c4.4 0 8-3.6 8-8V456c0-4.4-3.6-8-8-8z" + /> + </svg> + </span> + <div + className="ant-alert-content" + > + <div + className="ant-alert-description" + > + Encrypted msgs will be deprecated on Oct 17 + </div> + </div> + </div> </div>, ] at Object.<anonymous> (/work/cashtab/src/components/Send/__tests__/Send.test.js:88:18) at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:391:28) at new Promise (<anonymous>) at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:316:10) at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:218:40) at processTicksAndRejections (node:internal/process/task_queues:96:5) at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:155:3) at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:66:9) at run (/work/cashtab/node_modules/jest-circus/build/run.js:25:3) at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21) at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19) at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:389:16) at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:475:34) at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:133:12) ====== CashTab Unit Tests: Without wallet defined ====== Error: expect(received).toMatchSnapshot() Snapshot name: `Without wallet defined 1` - Snapshot - 0 + Received + 42 @@ -574,7 +574,49 @@ </div> </div> </form> </div> </div> + <div + className="ant-alert ant-alert-info ant-alert-with-description" + data-show={true} + role="alert" + style={ + Object { + "marginBottom": "10px", + } + } + > + <span + aria-label="info-circle" + className="anticon anticon-info-circle ant-alert-icon" + role="img" + > + <svg + aria-hidden="true" + data-icon="info-circle" + fill="currentColor" + focusable="false" + height="1em" + viewBox="64 64 896 896" + width="1em" + > + <path + d="M512 64C264.6 64 64 264.6 64 512s200.6 448 448 448 448-200.6 448-448S759.4 64 512 64zm0 820c-205.4 0-372-166.6-372-372s166.6-372 372-372 372 166.6 372 372-166.6 372-372 372z" + /> + <path + d="M464 336a48 48 0 1096 0 48 48 0 10-96 0zm72 112h-48c-4.4 0-8 3.6-8 8v272c0 4.4 3.6 8 8 8h48c4.4 0 8-3.6 8-8V456c0-4.4-3.6-8-8-8z" + /> + </svg> + </span> + <div + className="ant-alert-content" + > + <div + className="ant-alert-description" + > + Encrypted msgs will be deprecated on Oct 17 + </div> + </div> + </div> </div>, ] at Object.<anonymous> (/work/cashtab/src/components/Send/__tests__/Send.test.js:107:18) at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:391:28) at new Promise (<anonymous>) at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:316:10) at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:218:40) at processTicksAndRejections (node:internal/process/task_queues:96:5) at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:155:3) at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:66:9) at run (/work/cashtab/node_modules/jest-circus/build/run.js:25:3) at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21) at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19) at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:389:16) at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:475:34) at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
Each failure log is accessible here:
CashTab Unit Tests: Wallet without BCH balance
CashTab Unit Tests: Wallet with BCH balances
CashTab Unit Tests: Wallet with BCH balances and tokens
CashTab Unit Tests: Wallet with BCH balances and tokens and state field
CashTab Unit Tests: Without wallet defined
cashtab/src/components/Send/Send.js | ||
---|---|---|
1117 ↗ | (On Diff #42521) |
I suggest the following message: Encrypted messages are deprecated and the feature will be removed in a future update |
Failed tests logs:
====== CashTab Unit Tests: Wallet without BCH balance ====== Error: expect(received).toMatchSnapshot() Snapshot name: `Wallet without BCH balance 1` - Snapshot - 1 + Received + 1 @@ -617,11 +617,11 @@ className="ant-alert-content" > <div className="ant-alert-description" > - Encrypted msgs will be deprecated on Oct 17 + Encrypted messages are deprecated. The feature will be removed in a future update. </div> </div> </div> </div>, ] at Object.<anonymous> (/work/cashtab/src/components/Send/__tests__/Send.test.js:44:18) at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:391:28) at new Promise (<anonymous>) at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:316:10) at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:218:40) at processTicksAndRejections (node:internal/process/task_queues:96:5) at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:155:3) at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:66:9) at run (/work/cashtab/node_modules/jest-circus/build/run.js:25:3) at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21) at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19) at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:389:16) at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:475:34) at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:133:12) ====== CashTab Unit Tests: Wallet with BCH balances ====== Error: expect(received).toMatchSnapshot() Snapshot name: `Wallet with BCH balances 1` - Snapshot - 1 + Received + 1 @@ -617,11 +617,11 @@ className="ant-alert-content" > <div className="ant-alert-description" > - Encrypted msgs will be deprecated on Oct 17 + Encrypted messages are deprecated. The feature will be removed in a future update. </div> </div> </div> </div>, ] at Object.<anonymous> (/work/cashtab/src/components/Send/__tests__/Send.test.js:58:18) at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:391:28) at new Promise (<anonymous>) at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:316:10) at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:218:40) at processTicksAndRejections (node:internal/process/task_queues:96:5) at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:155:3) at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:66:9) at run (/work/cashtab/node_modules/jest-circus/build/run.js:25:3) at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21) at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19) at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:389:16) at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:475:34) at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:133:12) ====== CashTab Unit Tests: Wallet with BCH balances and tokens ====== Error: expect(received).toMatchSnapshot() Snapshot name: `Wallet with BCH balances and tokens 1` - Snapshot - 1 + Received + 1 @@ -617,11 +617,11 @@ className="ant-alert-content" > <div className="ant-alert-description" > - Encrypted msgs will be deprecated on Oct 17 + Encrypted messages are deprecated. The feature will be removed in a future update. </div> </div> </div> </div>, ] at Object.<anonymous> (/work/cashtab/src/components/Send/__tests__/Send.test.js:72:18) at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:391:28) at new Promise (<anonymous>) at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:316:10) at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:218:40) at processTicksAndRejections (node:internal/process/task_queues:96:5) at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:155:3) at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:66:9) at run (/work/cashtab/node_modules/jest-circus/build/run.js:25:3) at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21) at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19) at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:389:16) at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:475:34) at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:133:12) ====== CashTab Unit Tests: Wallet with BCH balances and tokens and state field ====== Error: expect(received).toMatchSnapshot() Snapshot name: `Wallet with BCH balances and tokens and state field 1` - Snapshot - 1 + Received + 1 @@ -623,11 +623,11 @@ className="ant-alert-content" > <div className="ant-alert-description" > - Encrypted msgs will be deprecated on Oct 17 + Encrypted messages are deprecated. The feature will be removed in a future update. </div> </div> </div> </div>, ] at Object.<anonymous> (/work/cashtab/src/components/Send/__tests__/Send.test.js:88:18) at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:391:28) at new Promise (<anonymous>) at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:316:10) at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:218:40) at processTicksAndRejections (node:internal/process/task_queues:96:5) at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:155:3) at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:66:9) at run (/work/cashtab/node_modules/jest-circus/build/run.js:25:3) at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21) at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19) at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:389:16) at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:475:34) at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:133:12) ====== CashTab Unit Tests: Without wallet defined ====== Error: expect(received).toMatchSnapshot() Snapshot name: `Without wallet defined 1` - Snapshot - 1 + Received + 1 @@ -612,11 +612,11 @@ className="ant-alert-content" > <div className="ant-alert-description" > - Encrypted msgs will be deprecated on Oct 17 + Encrypted messages are deprecated. The feature will be removed in a future update. </div> </div> </div> </div>, ] at Object.<anonymous> (/work/cashtab/src/components/Send/__tests__/Send.test.js:107:18) at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:391:28) at new Promise (<anonymous>) at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:316:10) at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:218:40) at processTicksAndRejections (node:internal/process/task_queues:96:5) at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:155:3) at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:66:9) at run (/work/cashtab/node_modules/jest-circus/build/run.js:25:3) at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21) at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19) at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:389:16) at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:475:34) at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
Each failure log is accessible here:
CashTab Unit Tests: Wallet without BCH balance
CashTab Unit Tests: Wallet with BCH balances
CashTab Unit Tests: Wallet with BCH balances and tokens
CashTab Unit Tests: Wallet with BCH balances and tokens and state field
CashTab Unit Tests: Without wallet defined
You should really fix the snapshots. It's a shame you have to do twice the update just because you forgot to update, it should be automatic