Paths

Table of Contentst

Differential D14598

Do not pass CChainParams& to BlockAssembler constructor
ClosedPublic
Actions

Authored by PiRK on Oct 4 2023, 16:16.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC1cefbf55e5f9: Do not pass CChainParams& to BlockAssembler constructor

Summary

This is a partial backport of core#25168
https://github.com/bitcoin/bitcoin/pull/25168/commits/fafe5c0ca2927642cbcec63ac73994737e1653d6

Depends on D14597

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 4 2023, 16:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 4 2023, 16:16

PiRK requested review of this revision.Oct 4 2023, 16:16

teamcity edited the summary of this revision. (Show Details)Oct 4 2023, 16:17

PiRK added a child revision: D14599: Do not pass CChainParams& to PeerManager::make.Oct 4 2023, 16:18

Harbormaster completed remote builds in B25267: Diff 42543.Oct 4 2023, 16:47

Fabien accepted this revision.Oct 4 2023, 18:24

This revision is now accepted and ready to land.Oct 4 2023, 18:24

Closed by commit rABC1cefbf55e5f9: Do not pass CChainParams& to BlockAssembler constructor (authored by PiRK). · Explain WhyOct 5 2023, 03:34

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1cefbf55e5f9: Do not pass CChainParams& to BlockAssembler constructor.

Revision Contents
Changeset List

Path

Size

src/

bench/

chained_tx.cpp

2 lines

node/

miner.h

4 lines

miner.cpp

10 lines

rpc/

mining.cpp

8 lines

test/

blockfilter_index_tests.cpp

4 lines

miner_tests.cpp

12 lines

util/

setup_common.cpp

2 lines

validation_block_tests.cpp

4 lines

Diff 42553

View Options

src/bench/chained_tx.cpp

View Options

src/node/miner.h

View Options

src/node/miner.cpp

View Options

src/rpc/mining.cpp

View Options

src/test/blockfilter_index_tests.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/util/setup_common.cpp

View Options

src/test/validation_block_tests.cpp

Do not pass CChainParams& to BlockAssembler constructorClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42553

src/bench/chained_tx.cpp

src/node/miner.h

src/node/miner.cpp

src/rpc/mining.cpp

src/test/blockfilter_index_tests.cpp

src/test/miner_tests.cpp

src/test/util/setup_common.cpp

src/test/validation_block_tests.cpp

Do not pass CChainParams& to BlockAssembler constructor
ClosedPublic
Actions

Revision Contents
Changeset List