Paths

Table of Contentst

Differential D14605

[electrum] fix x_pubkey format in multisig wallet
ClosedPublic
Actions

Authored by PiRK on Oct 5 2023, 13:04.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC755e0fa69c34: [electrum] fix x_pubkey format in multisig wallet

Summary

For now the wallet still works with coin dicts containing hex strings. D14594 converted keystore.get_xpubkey to return bytes, and applied the correct hex conversion in SimpleDeterministicWallet.add_input_sig_info, but missed the conversion in MultisigWallet.add_input_sig_info

Test Plan

python test_runner.py

Send a transaction with a multisig setup

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 5 2023, 13:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2023, 13:04

PiRK requested review of this revision.Oct 5 2023, 13:04

Harbormaster completed remote builds in B25283: Diff 42572.Oct 5 2023, 13:05

Fabien accepted this revision.Oct 5 2023, 14:08

This revision is now accepted and ready to land.Oct 5 2023, 14:08

Closed by commit rABC755e0fa69c34: [electrum] fix x_pubkey format in multisig wallet (authored by PiRK). · Explain WhyOct 5 2023, 15:22

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC755e0fa69c34: [electrum] fix x_pubkey format in multisig wallet.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

tests/

test_wallet_vertical.py

32 lines

4 lines

Diff 42573

electrum/electrumabc/tests/test_wallet_vertical.py

Loading...

electrum/electrumabc/wallet.py

Loading...