Paths

Table of Contentst

Differential D14594

[electrum] progress converting keystore.py to using bytes
ClosedPublic
Actions

Authored by PiRK on Oct 4 2023, 13:55.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC8d71c7c66119: [electrum] progress converting keystore.py to using bytes

Summary

D14592 and D14593 were minimal changes just to fix a bug. This continues the job of consistently using and returning bytes everywhere in keystore.py.
After this, the remaining str attributes are self.xpub and self.xprv in BIP32KeyStore. Those are base58 encoded ("xpub...", "xprv..."), so converting to bytes is less trivial.

Depends on D14593

Test Plan

python test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 4 2023, 13:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 4 2023, 13:55

PiRK requested review of this revision.Oct 4 2023, 13:55

PiRK added a child revision: D14595: [electrum] remove last usages of int_to_le_hex and rev_hex.

Harbormaster completed remote builds in B25263: Diff 42537.Oct 4 2023, 13:56

PiRK edited the summary of this revision. (Show Details)Oct 4 2023, 13:59

PiRK edited the summary of this revision. (Show Details)

Fabien accepted this revision.Oct 4 2023, 18:11

This revision is now accepted and ready to land.Oct 4 2023, 18:11

Closed by commit rABC8d71c7c66119: [electrum] progress converting keystore.py to using bytes (authored by PiRK). · Explain WhyOct 5 2023, 03:41

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC8d71c7c66119: [electrum] progress converting keystore.py to using bytes.

PiRK mentioned this in D14605: [electrum] fix x_pubkey format in multisig wallet.Oct 5 2023, 13:04

PiRK mentioned this in rABC755e0fa69c34: [electrum] fix x_pubkey format in multisig wallet.Oct 5 2023, 15:22

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

69 lines

tests/

test_consolidate.py

2 lines

test_wallet_vertical.py

18 lines

6 lines

Diff 42557

electrum/electrumabc/keystore.py

Loading...

electrum/electrumabc/tests/test_consolidate.py

Loading...

electrum/electrumabc/tests/test_wallet_vertical.py

Loading...

electrum/electrumabc/wallet.py

Loading...