[electrum] fix OldKeyStore.get_pubkey_derivation
ClosedPublic
Actions

Authored by PiRK on Oct 4 2023, 12:53.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC6cb98fda1e23: [electrum] fix OldKeyStore.get_pubkey_derivation

Summary

Same issue as D14592, but for the "old" keystore.

Test Plan

python test_runner.py

Create a wallet from the same seed as the unit test, check that you can receive and send transactions.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 4 2023, 12:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 4 2023, 12:53

PiRK requested review of this revision.Oct 4 2023, 12:53

Harbormaster completed remote builds in B25262: Diff 42536.Oct 4 2023, 12:55

PiRK added a child revision: D14594: [electrum] progress converting keystore.py to using bytes.Oct 4 2023, 13:55

Fabien accepted this revision.Oct 4 2023, 18:07

This revision is now accepted and ready to land.Oct 4 2023, 18:07

Closed by commit rABC6cb98fda1e23: [electrum] fix OldKeyStore.get_pubkey_derivation (authored by PiRK). · Explain WhyOct 5 2023, 03:41

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC6cb98fda1e23: [electrum] fix OldKeyStore.get_pubkey_derivation.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

keystore.py

22 lines

tests/

test_keystore.py

23 lines

Diff 42556

View Options

electrum/electrumabc/keystore.py