Make a page where people can find information about upcoming upgrades
Details
Details
- Reviewers
johnkuney Fabien bytesofman - Group Reviewers
Restricted Project - Commits
- rABC95fad4bdc3a7: [e.cash] Add upgrade page
Ran it locally to check rendering looks good
Read through the content to make sure it's correct
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/e.cash/pages/upgrade.js | ||
|---|---|---|
| 73–76 ↗ | (On Diff #42609) | self-evident |
Comment Actions
Yeah overall looks good. Left some comments
| web/e.cash/pages/upgrade.js | ||
|---|---|---|
| 9 ↗ | (On Diff #42609) | where did you want to use this image? You imported it, but didn't put it anywhere |
| 28 ↗ | (On Diff #42609) | can use <p>'s here instead of <ul>'s |
| 32 ↗ | (On Diff #42609) | Should use <Link> for any links. Its already imported at the top so can just update the <a></a> to <Link></Link> |
| 36 ↗ | (On Diff #42609) | <p> |
| 50 ↗ | (On Diff #42609) | I'd lose the <ul> and <li>s and just have <b>...</b><p>...</p> |
| 81 ↗ | (On Diff #42609) | <p> and use <Link> |
Comment Actions
Use animation instead of image
Remove pointless explanation regarding miner fund increase
Add some comments about what miners need to do
Various fixes per comments
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) failed.
Tail of the build log:
#4 extracting sha256:ca266fd6192108b67fb57b74753a8c4ca5d8bd458baae3d4df7ce9f42dedcc1d 0.1s done #4 extracting sha256:ee7d78be1eb92caf6ae84fc3af736b23eca018d5dedc967ae5bdee6d7082403b done #4 DONE 7.5s #6 [2/4] COPY . . #6 sha256:9eaf9f58937463eb8a6996c28f8668f91687306f4e6670cd286e61c7b53ce99f #6 DONE 1.1s #7 [3/4] RUN npm ci #7 sha256:f0ec36e517040b0fb4ffe27fd9d1830108b5ce6f4c3407f786b40321e581fe67 #7 10.02 #7 10.02 added 810 packages, and audited 811 packages in 9s #7 10.02 #7 10.02 153 packages are looking for funding #7 10.02 run `npm fund` for details #7 10.05 #7 10.05 6 moderate severity vulnerabilities #7 10.05 #7 10.05 To address issues that do not require attention, run: #7 10.05 npm audit fix #7 10.05 #7 10.05 To address all issues, run: #7 10.05 npm audit fix --force #7 10.05 #7 10.05 Run `npm audit` for details. #7 10.06 npm notice #7 10.06 npm notice New major version of npm available! 8.19.4 -> 10.2.0 #7 10.06 npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0> #7 10.06 npm notice Run `npm install -g npm@10.2.0` to update! #7 10.06 npm notice #7 DONE 14.3s #8 [4/4] RUN npm run build #8 sha256:f32eecc425d89f109ff2f04034def81d03ffd65193bb6618c28a89ae43713ca1 #8 0.795 #8 0.795 > e.cash@0.0.1 build #8 0.795 > next build #8 0.795 #8 1.146 Attention: Next.js now collects completely anonymous telemetry regarding usage. #8 1.147 This information is used to shape Next.js' roadmap and prioritize features. #8 1.147 You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL: #8 1.147 https://nextjs.org/telemetry #8 1.147 #8 1.236 info - Linting and checking validity of types... #8 3.793 #8 3.793 Failed to compile. #8 3.793 #8 3.793 ./pages/upgrade.js #8 3.793 41:46 Error: `"` can be escaped with `"`, `“`, `"`, `”`. react/no-unescaped-entities #8 3.793 41:63 Error: `"` can be escaped with `"`, `“`, `"`, `”`. react/no-unescaped-entities #8 3.793 44:61 Error: `'` can be escaped with `'`, `‘`, `'`, `’`. react/no-unescaped-entities #8 3.793 60:71 Error: `'` can be escaped with `'`, `‘`, `'`, `’`. react/no-unescaped-entities #8 3.793 #8 3.793 info - Need to disable some ESLint rules? Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules #8 ERROR: executor failed running [/bin/sh -c npm run build]: exit code: 1 ------ > [4/4] RUN npm run build: ------ executor failed running [/bin/sh -c npm run build]: exit code: 1 Build preview-e.cash failed with exit code 1
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.220.62:41903 for the next 60 minutes.