[electrum] better handle timeouts in test_interface
ClosedPublic
Actions

Authored by PiRK on Oct 10 2023, 10:26.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCbb75088d2f12: [electrum] better handle timeouts in test_interface

Summary

Tests are failing on CI because we don't catch the correct error for python < 3.10

badssl.com seems to be unresponsive, lately. If this keeps happening, this test should be removed to not slow down the test suite unnecessarily.

Test Plan

python -m electrumabc.tests.test_interface

Diff Detail

Repository

rABC Bitcoin ABC

Branch

socket_timeout

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25311
Build 50206: Build Diff	electrum-tests
Build 50205: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 10 2023, 10:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 10 2023, 10:26

PiRK requested review of this revision.Oct 10 2023, 10:26

Harbormaster completed remote builds in B25311: Diff 42613.Oct 10 2023, 10:28

Fabien accepted this revision.Oct 10 2023, 12:04

This revision is now accepted and ready to land.Oct 10 2023, 12:04

Closed by commit rABCbb75088d2f12: [electrum] better handle timeouts in test_interface (authored by PiRK). · Explain WhyOct 10 2023, 13:02

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCbb75088d2f12: [electrum] better handle timeouts in test_interface.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

tests/

test_interface.py

9 lines

Diff 42613

View Options

electrum/electrumabc/tests/test_interface.py

[electrum] better handle timeouts in test_interfaceClosedPublicActions