Page MenuHomePhabricator

[e.cash] Modify announcement bar for network upgrade
ClosedPublic

Authored by johnkuney on Oct 11 2023, 15:28.

Details

Reviewers
Mengerian
Group Reviewers
Restricted Project
Commits
rABC726a317bcb38: [e.cash] Modify announcement bar for network upgrade
Summary

Update the text and link and adding a countdown clock to the annoucnement bar for the upcoming network update

Test Plan

preview the site and check the bar looks good and links to /upgrade.

You could also try running locally and change the ACTIVATION_TIMESTAMP value to Date.now() + 5000 to see how the end timer will go

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-update-annoucement-bar
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25325
Build 50231: Build Diff
Build 50230: arc lint + arc unit

Event Timeline

Mengerian requested changes to this revision.Oct 11 2023, 18:08

Can it be made to say “days” instead of just another colon separating the first number?

Maybe it’s just me but takes some mental parsing to interpret the number

web/e.cash/components/announcement-bar/index.js
7

Why is this adding 1000?

Should probably follow the same pattern as D14622

web/e.cash/components/navbar/index.js
67
This revision now requires changes to proceed.Oct 11 2023, 18:08

add days label, stack lines, add 3hr buffer to complete timestamp

Okay added those tweaks. The times need to be in ms for this package hence the difference there

This revision is now accepted and ready to land.Oct 11 2023, 21:51