Update the text and link and adding a countdown clock to the annoucnement bar for the upcoming network update
Details
Details
- Reviewers
Mengerian - Group Reviewers
Restricted Project - Commits
- rABC726a317bcb38: [e.cash] Modify announcement bar for network upgrade
preview the site and check the bar looks good and links to /upgrade.
You could also try running locally and change the ACTIVATION_TIMESTAMP value to Date.now() + 5000 to see how the end timer will go
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- ecash-update-annoucement-bar
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 25329 Build 50239: Build Diff Build 50238: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41019 for the next 60 minutes.
Comment Actions
Can it be made to say “days” instead of just another colon separating the first number?
Maybe it’s just me but takes some mental parsing to interpret the number
| web/e.cash/components/announcement-bar/index.js | ||
|---|---|---|
| 7 ↗ | (On Diff #42633) | Why is this adding 1000? Should probably follow the same pattern as D14622 |
| web/e.cash/components/navbar/index.js | ||
| 67 ↗ | (On Diff #42633) | |
Comment Actions
Okay added those tweaks. The times need to be in ms for this package hence the difference there
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41195 for the next 60 minutes.