Differential D14631

[e.cash] Language selector CSS
ClosedPublic
Actions

Authored by johnkuney on Oct 12 2023, 03:45.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC269bd39b750b: [e.cash] Language selector CSS

Summary

Adding some overrides and a new hover effect on the language selector styles

Screen Shot 2023-10-12 at 10.59.21 AM.png (1×1 px, 1 MB)

Screen Shot 2023-10-12 at 10.59.59 AM.png (724×708 px, 186 KB)

Screen Shot 2023-10-12 at 11.00.38 AM.png (460×698 px, 235 KB)

It is a rectangle now on the live site, but it should be a square. The padding values coming from weglot changed at some point

Test Plan

Can only test live due to weglot setup, but the selector will be a square again with these css edits

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

johnkuney created this revision.Oct 12 2023, 03:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2023, 03:45

johnkuney requested review of this revision.Oct 12 2023, 03:45

Harbormaster completed remote builds in B25336: Diff 42649.Oct 12 2023, 03:45

remove classname

Harbormaster completed remote builds in B25337: Diff 42650.Oct 12 2023, 03:47

Fabien retitled this revision from [e.cash] Languuage selector CSS to [e.cash] Language selector CSS.Oct 12 2023, 08:06

The title and summary tell the CSS has changed and needs to be updated, but:

What has changed ? What is the problem with the current design ?
What is the expected result after this change ?

Right now I can't review this diff because I have no idea what it's supposed to do. Also the test plan say the selector *should* be square again but I see nothing related to the border shape in this diff.
If it's too complicated to explain, at least put some screenshots.

This revision now requires changes to proceed.Oct 12 2023, 08:09

Ah my bad, was assuming you saw the message from David in the telegram channel. But if you go to the live site you'll see the language selector is a rectangle now, with the text off to the left. (see first screenshot below)

Its meant to be a square with centered text. This *will be* the result of this diff

The issue is coming from these weglot styles.

johnkuney requested review of this revision.Oct 12 2023, 16:21

In D14631#328660, @johnkuney wrote:

Ah my bad, was assuming you saw the message from David in the telegram channel. But if you go to the live site you'll see the language selector is a rectangle now, with the text off to the left. (see first screenshot below)

Its meant to be a square with centered text. This *will be* the result of this diff

The issue is coming from these weglot styles.

Please put that info in the diff title/summary. It ends up in the git history, nobody will dig into comments or telegram channel to figure out why this was added in 1 year from now.

Fabien requested changes to this revision.Oct 12 2023, 17:10

This revision now requires changes to proceed.Oct 12 2023, 17:10

johnkuney edited the summary of this revision. (Show Details)Oct 12 2023, 17:35

johnkuney edited the test plan for this revision. (Show Details)

johnkuney requested review of this revision.Oct 12 2023, 17:37

Fabien accepted this revision.Oct 12 2023, 19:38

This revision is now accepted and ready to land.Oct 12 2023, 19:38

Closed by commit rABC269bd39b750b: [e.cash] Language selector CSS (authored by johnkuney). · Explain WhyOct 12 2023, 19:54

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABC269bd39b750b: [e.cash] Language selector CSS.