Adding some overrides and a new hover effect on the language selector styles
It is a rectangle now on the live site, but it should be a square. The padding values coming from weglot changed at some point
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC269bd39b750b: [e.cash] Language selector CSS
Can only test live due to weglot setup, but the selector will be a square again with these css edits
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- ecash-fix-countdown-weglot
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 25336 Build 50253: Build Diff Build 50252: arc lint + arc unit
Event Timeline
Comment Actions
The title and summary tell the CSS has changed and needs to be updated, but:
- What has changed ? What is the problem with the current design ?
- What is the expected result after this change ?
Right now I can't review this diff because I have no idea what it's supposed to do. Also the test plan say the selector *should* be square again but I see nothing related to the border shape in this diff.
If it's too complicated to explain, at least put some screenshots.
Comment Actions
Its meant to be a square with centered text. This *will be* the result of this diff
Ah my bad, was assuming you saw the message from David in the telegram channel. But if you go to the live site you'll see the language selector is a rectangle now, with the text off to the left. (see first screenshot below)
Its meant to be a square with centered text. This *will be* the result of this diff
The issue is coming from these weglot styles.
Comment Actions
Ah my bad, was assuming you saw the message from David in the telegram channel. But if you go to the live site you'll see the language selector is a rectangle now, with the text off to the left. (see first screenshot below)
Its meant to be a square with centered text. This *will be* the result of this diffThe issue is coming from these weglot styles.
Please put that info in the diff title/summary. It ends up in the git history, nobody will dig into comments or telegram channel to figure out why this was added in 1 year from now.