Page MenuHomePhabricator
Differential D1463

Get rid of BlockStatusEnum
ClosedPublic
Actions

Authored by deadalnix on May 27 2018, 22:19.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGf46bf9c4c9f8: Get rid of BlockStatusEnum
rABCf46bf9c4c9f8: Get rid of BlockStatusEnum
Summary

It publicly expose machinery internal to BlockStatus.

Depends on D1462

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
killBlockStatusEnum
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2670
Build 3452: Bitcoin ABC Buildbot (legacy)
Build 3451: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 27 2018, 22:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 27 2018, 22:19
teamcity added a subscriber: teamcity.May 27 2018, 22:21

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 27 2018, 22:55

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2662: Diff 4004.May 27 2018, 22:55
jasonbcox requested changes to this revision.May 28 2018, 18:21
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/chain.h
182 ↗(On Diff #4004)

Is there a more descriptive name we can give this? DATA_ON_DISK_FLAG perhaps?

184 ↗(On Diff #4004)

This sounds like it's undoing some flag(s). Call it something like UNDO_DATA_FLAG instead. Depending on the above comment, UNDO_DATA_ON_DISK_FLAG might work as well.

This revision now requires changes to proceed.May 28 2018, 18:21
deadalnix added inline comments.May 28 2018, 21:05
src/chain.h
182 ↗(On Diff #4004)

We don't really care where the data are.

jasonbcox accepted this revision.May 29 2018, 00:11
jasonbcox added inline comments.
src/chain.h
182 ↗(On Diff #4004)

Fair enough.

This revision is now accepted and ready to land.May 29 2018, 00:11
deadalnix updated this revision to Diff 4019.May 29 2018, 10:24

Update DATA_FLAG and UNDO_FLAG to HAS_DATA_FLAG and HAS_UNDO_FLAG.

teamcity added a comment.May 29 2018, 10:24

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Closed by commit rABCf46bf9c4c9f8: Get rid of BlockStatusEnum (authored by deadalnix). · Explain WhyMay 29 2018, 10:30
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B2670: Diff 4019.May 29 2018, 10:58
teamcity added a comment.May 29 2018, 10:58

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Revision Contents
Changeset List

PathSize
src/
77 lines

Diff 4019

View Options

src/chain.h

Loading...