Page MenuHomePhabricator
Differential D14656

doc: add assumeutxo notes
ClosedPublic
Actions

Authored by PiRK on Oct 19 2023, 15:46.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf58299dfffd7: doc: add assumeutxo notes
Summary

This is a backport of core#23154
with updates from core#25667 and core#25740

Depends on D14655

Test Plan

proof-reading

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 19 2023, 15:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 19 2023, 15:46
PiRK requested review of this revision.Oct 19 2023, 15:46
teamcity edited the summary of this revision. (Show Details)Oct 19 2023, 15:46
Harbormaster completed remote builds in B25380: Diff 42715.Oct 19 2023, 15:46
PiRK edited the summary of this revision. (Show Details)Oct 19 2023, 15:47
PiRK added a parent revision: D14655: test: add testcases for snapshot initialization.
Fabien accepted this revision.Oct 23 2023, 13:16
Fabien added a subscriber: Fabien.
Fabien added inline comments.
doc/assumeutxo.md
56 ↗(On Diff #42715)

??? Why did they put an empty row ?

106 ↗(On Diff #42715)

This raises questions:

  • Is snapshot loading compatible with reindexing ? If the node is doing a reindex, can it load a snapshot ?
  • Is it compatible with pruning ? I think it should be but worth checking
This revision is now accepted and ready to land.Oct 23 2023, 13:16
PiRK added inline comments.Oct 24 2023, 04:38
doc/assumeutxo.md
106 ↗(On Diff #42715)

There is no incompatibility with pruning. The background IBD chainstate can be pruned aggressively because we know there will be no reorg.

I don't think it will be compatible with reindexing. There is a commit in core#27596 that causes the snapshot chainstate to be deleted if -reindex is used. I'm not sure what happens if loadtxoustset is called during a reindexing. I will have to try it when backporting the last PR

Closed by commit rABCf58299dfffd7: doc: add assumeutxo notes (authored by James O'Beirne <james.obeirne@pm.me>, committed by PiRK). · Explain WhyOct 26 2023, 11:32
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCf58299dfffd7: doc: add assumeutxo notes.

Revision Contents
Changeset List

PathSize
doc/
1 line
140 lines

Diff 42805

View Options

doc/README.md

Loading...
View Options

doc/assumeutxo.md

Loading...