Refactor blockstatus_tests.cpp to avoid deep nesting.
ClosedPublic
Actions

Authored by deadalnix on May 29 2018, 11:33.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING2d071c9612e8: Refactor blockstatus_tests.cpp to avoid deep nesting.
rABC2d071c9612e8: Refactor blockstatus_tests.cpp to avoid deep nesting.

Summary

As per title.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.May 29 2018, 11:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 29 2018, 11:33

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2671: Diff 4021.May 29 2018, 12:08

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

deadalnix added a child revision: D1469: Introduce the concept of parked chain..May 29 2018, 19:23

One nit that was confusing to read. Looks good otherwise.

src/test/blockstatus_tests.cpp
81 ↗	(On Diff #4021)	CheckHaveAndUndo -> CheckDataAndUndo

This revision now requires changes to proceed.Jun 5 2018, 22:51

Update naming as per request

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2705: Diff 4069.Jun 6 2018, 00:18

jasonbcox accepted this revision.Jun 7 2018, 22:32

This revision is now accepted and ready to land.Jun 7 2018, 22:32

Closed by commit rABC2d071c9612e8: Refactor blockstatus_tests.cpp to avoid deep nesting. (authored by deadalnix). · Explain WhyJun 8 2018, 14:53

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

blockstatus_tests.cpp

123 lines

Diff 4088

View Options

src/test/blockstatus_tests.cpp

Refactor blockstatus_tests.cpp to avoid deep nesting.ClosedPublicActions