Page MenuHomePhabricator
Differential D14669

rpc: various fixups for dumptxoutset
ClosedPublic
Actions

Authored by PiRK on Oct 24 2023, 07:08.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4ce0b8d8253c: rpc: various fixups for dumptxoutset
Summary
  • Actually generate an assumeutxo hash and display it
  • Add nchaintx to output (necessary for use in chainparams entry)

The source PR actually duplicated the "path" field in the output. Don't do that.

This is a backport of core#23155

Depends on D14657

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 24 2023, 07:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 24 2023, 07:08
PiRK requested review of this revision.Oct 24 2023, 07:08
teamcity edited the summary of this revision. (Show Details)Oct 24 2023, 07:08
Harbormaster completed remote builds in B25402: Diff 42737.Oct 24 2023, 07:22
PiRK added a child revision: D14671: fuzz: Remove useless GetUTXOStats fuzz case.Oct 24 2023, 08:43
Fabien requested changes to this revision.Oct 25 2023, 08:40
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/blockchain.cpp
3160 ↗(On Diff #42737)

Macro lolfail:

test/functional/rpc_dumptxoutset.py
53 ↗(On Diff #42737)

Can we check the paths as well ? It would have prevented the previous bug

This revision now requires changes to proceed.Oct 25 2023, 08:40
PiRK added inline comments.Oct 25 2023, 11:28
test/functional/rpc_dumptxoutset.py
53 ↗(On Diff #42737)

done on line 34

PiRK updated this revision to Diff 42785.EditedOct 25 2023, 11:29
PiRK edited the summary of this revision. (Show Details)

dedup "path"

It seems a bit silly to add two new params to a function just for a log line, but I think it is best to stay close to the source material on this, to reduce head-scratching and git blaming on future backports..

Harbormaster completed remote builds in B25434: Diff 42785.Oct 25 2023, 11:43
Fabien accepted this revision.Oct 26 2023, 08:59
This revision is now accepted and ready to land.Oct 26 2023, 08:59
Closed by commit rABC4ce0b8d8253c: rpc: various fixups for dumptxoutset (authored by James O'Beirne <james.obeirne@gmail.com>, committed by PiRK). · Explain WhyOct 26 2023, 11:39
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC4ce0b8d8253c: rpc: various fixups for dumptxoutset.

Revision Contents
Changeset List

PathSize
src/
rpc/
4 lines
25 lines
test/
util/
5 lines
test/
functional/
6 lines

Diff 42807

View Options

src/rpc/blockchain.h

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/test/util/chainstate.h

Loading...
View Options

test/functional/rpc_dumptxoutset.py

Loading...