The min-max score checker for exchanges was resolving null values as 0 and therefore meeting the threshold as true if the
min check was 0. This was causing a handful of scores to be higher than they should be.
Added a check to ignore null values so the scores are computed properly, and updated the test data to reflect this
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC0a9077e3be7d: [e.cash] getScores edit
Preview the app and check the get-ecash page renders properly and the order of the items matches scorecard.cash, specifically the instant exchanges
check tests still pass - npm run test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- ecash-getscores-modifications
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 25476 Build 50533: Build Diff Build 50532: arc lint + arc unit