Page MenuHomePhabricator

[e.cash] getScores edit
ClosedPublic

Authored by johnkuney on Oct 30 2023, 18:48.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0a9077e3be7d: [e.cash] getScores edit
Summary

The min-max score checker for exchanges was resolving null values as 0 and therefore meeting the threshold as true if the
min check was 0. This was causing a handful of scores to be higher than they should be.
Added a check to ignore null values so the scores are computed properly, and updated the test data to reflect this

Test Plan

Preview the app and check the get-ecash page renders properly and the order of the items matches scorecard.cash, specifically the instant exchanges
check tests still pass - npm run test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Oct 30 2023, 19:29
This revision was automatically updated to reflect the committed changes.