Page MenuHomePhabricator
Differential D14708

[Cashtab][Swap] Add swap component with SideShift integration
ClosedPublic
Actions

Authored by emack on Oct 31 2023, 06:47.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC8b10270ebb71: [Cashtab][Swap] Add swap component with SideShift integration
Summary

T3322

For reals this time.

Adds the Swap component with SideShift being the first cab off the rank.

The SideShift button is also accessible on the Home onboarding screen when the user creates a new wallet with a zero balance.

In terms of the user closing the widget in the middle of a shift transaction (accidentally or otherwise), re-opening it via the same button will display the previous ongoing transaction for the user to complete the shift.

Test Plan
  • npm test
  • npm start
  • Create a fresh new wallet and observe the Exchange to XEC via SideShift button is rendered on the onboarding Home screen. Click it and observe successful rendering of the SideShift widget overlay.
  • Switch to an existing wallet with tx history and observe the Exchange to XEC via SideShift button is not rendered on the Home screen and instead has the expected Tx History displayed
  • Click on the hamburger menu and navigate to the Swap component. Observe the balance header is displayed and then open the SideShift dropdown and click the button to render the SideShift widget overlay
  • Start an USDT to XEC swap process Waiting for you to send USDT..., close the SideShift widget overlay, then re-click the Open SideShift button and ensure the previous incomplete swap process is still displayed.
  • Complete the USDT to XEC swap process and ensure the exchanged XEC is sent to the designated settlement eCash address.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emack created this revision.Oct 31 2023, 06:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 31 2023, 06:47
emack requested review of this revision.Oct 31 2023, 06:47
emack changed the visibility from "Public (No Login Required)" to "Restricted Project (Project)".Oct 31 2023, 06:47
emack planned changes to this revision.Oct 31 2023, 06:50
This comment was removed by emack.
Harbormaster completed remote builds in B25480: Diff 42866.Oct 31 2023, 06:50
emack updated this revision to Diff 42867.Oct 31 2023, 06:54

Updated test snapshot for Home

Harbormaster completed remote builds in B25481: Diff 42867.Oct 31 2023, 06:57
bytesofman added a comment.Oct 31 2023, 19:25

Seems like this is as good as we can get with the widget implementation.

Are there any obstructions to doing a deeper integration using their API?

It's probably worth getting this in first, just so we have something available and can get an idea of demand. But also worth considering. If it's popular, we would want a Cashtab themed integration, and especially to pull in the user's address.

bytesofman added a comment.Oct 31 2023, 19:30

Provide overlay override as the default layout positions the close (X) button above the top browser bar

I'm not seeing this issue today. Maybe it was caused by toggling in and out of the dev panel and different frame sizes.

bytesofman requested changes to this revision.Oct 31 2023, 19:33
bytesofman added inline comments.
cashtab/src/components/Home/Home.js
157 ↗(On Diff #42867)

Should handle the case of this being undefined for whatever reason (mb the widget is broken, something has loaded improperly).

Need some kind of validation that window.sideshift is what we want it to be. If it isn't, some way to disable the button.

This revision now requires changes to proceed.Oct 31 2023, 19:33
emack updated this revision to Diff 42894.Nov 1 2023, 01:14
emack marked an inline comment as done.

Added isValidSideshiftObj() along with unit tests to validation.js to check that the instantiated sideshift object contains the expected APIs. If not valid, an error is displayed in place of the button in Swap.js. This can be verified by malforming the sidieshift library url in /public/index.html header.

It's probably worth getting this in first

Yup agreed, we'll need to work in closely with their team for a deeper integration via their API. If you're thinking of Cashtab components and UI mimicing their widget then this'll be a decent chuck of work but doable.

I'm not seeing this issue today. Maybe it was caused by toggling in and out of the dev panel and different frame sizes.

I raised with the SideShift team yesterday via tg and they fixed it along with the cancel order bug.

emack edited the summary of this revision. (Show Details)Nov 1 2023, 01:15
Harbormaster completed remote builds in B25503: Diff 42894.Nov 1 2023, 01:31
emack changed the visibility from "Restricted Project (Project)" to "Public (No Login Required)".Nov 1 2023, 03:46
emack updated this revision to Diff 42896.Nov 1 2023, 07:10

Setting the IFP address as the settlement address.

emack added a subscriber: Mengerian.Nov 1 2023, 07:12
emack added inline comments.
cashtab/public/index.html
47 ↗(On Diff #42896)

@Mengerian to advise on official ABC id

Harbormaster completed remote builds in B25505: Diff 42896.Nov 1 2023, 07:25
bytesofman added a comment.Nov 1 2023, 18:01

I raised with the SideShift team yesterday via tg and they fixed it along with the cancel order bug.

dang very nice

emack updated this revision to Diff 42950.EditedNov 5 2023, 12:30
  • parentAffiliatedId set to the official ABC account from Antony
  • Reverted settleAddress back to undefined otherwise the Receiving Address field will not be displayed in the widget. Whoever is managing the ABC account can just execute monthly withdrawals from the official account to the IFP address.

image.png (142×561 px, 7 KB)

Harbormaster completed remote builds in B25533: Diff 42950.Nov 5 2023, 12:33
bytesofman requested changes to this revision.Nov 6 2023, 22:20

image.png (169×393 px, 6 KB)

This doesn't work in the extension -- prob violates the security policy pulling in scripts from another website.

Back out the routing changes for the extension. If we implement it in the extension, will need to be with the API.

This revision now requires changes to proceed.Nov 6 2023, 22:20
emack updated this revision to Diff 42967.Nov 7 2023, 01:07

Backing out extension changes

Harbormaster completed remote builds in B25545: Diff 42967.Nov 7 2023, 01:09
bytesofman requested changes to this revision.Nov 8 2023, 21:53
bytesofman added inline comments.
cashtab/src/components/Home/Home.js
229–231 ↗(On Diff #42967)

this should only appear if isValidSideshift(sideshift)

This revision now requires changes to proceed.Nov 8 2023, 21:53
bytesofman accepted this revision.Nov 8 2023, 21:53

calling 'accepted' as requested change is more of a nit

This revision is now accepted and ready to land.Nov 8 2023, 21:53
emack updated this revision to Diff 43010.Nov 8 2023, 23:36

Updated nit

Harbormaster completed remote builds in B25574: Diff 43010.Nov 8 2023, 23:41
Closed by commit rABC8b10270ebb71: [Cashtab][Swap] Add swap component with SideShift integration (authored by emack). · Explain WhyNov 8 2023, 23:47
This revision was automatically updated to reflect the committed changes.
emack added a commit: rABC8b10270ebb71: [Cashtab][Swap] Add swap component with SideShift integration.

Revision Contents
Changeset List

PathSize
cashtab/
public/
12 lines
src/
components/
22 lines
Common/
3 lines
Home/
12 lines
__tests__/
__snapshots__/
10 lines
Swap/
87 lines
__tests__/
108 lines
__snapshots__/
666 lines
utils/
__tests__/
30 lines
17 lines

Diff 43011

View Options

cashtab/public/index.html

Loading...
View Options

cashtab/src/components/App.js

Loading...
View Options

cashtab/src/components/Common/CustomIcons.js

Loading...
View Options

cashtab/src/components/Home/Home.js

Loading...
View Options

cashtab/src/components/Home/__tests__/__snapshots__/Home.test.js.snap

Loading...
View Options

cashtab/src/components/Swap/Swap.js

Loading...
View Options

cashtab/src/components/Swap/__tests__/Swap.test.js

Loading...
View Options

cashtab/src/components/Swap/__tests__/__snapshots__/Swap.test.js.snap

Loading...
View Options

cashtab/src/utils/__tests__/validation.test.js

Loading...
View Options

cashtab/src/utils/validation.js

Loading...