The expected behavior is to return true if the payout script was set successfully. However the actual return value comes from the std::unordered_map::insert_or_assign that returns true on insertion but false on assignment. This diff fixes the return value to be compliant with the expected return value for the RPC.
Details
Details
- Reviewers
PiRK - Group Reviewers
Restricted Project - Commits
- rABC91d9dc66e1b1: [avalanche] Fix the return status of the setstakingreward RPC
./test/functional/test_runner.py abc_mining_stakingrewards
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- setstakingreward_return_value
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 25490 Build 50561: Build Diff build-clang-tidy · lint-circular-dependencies · build-debug · build-clang · build-without-wallet · build-diff Build 50560: arc lint + arc unit