Page MenuHomePhabricator

[Cashtab] Seed warning confirmation check
ClosedPublic

Authored by emack on Nov 1 2023, 06:58.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC7d6047f1d2a8: [Cashtab] Seed warning confirmation check
Summary

T3329

Adds a conditional warning upon opening the seed phrase dropdown in Settings whereby the user needs to click the checkbox for the seed to be displayed.

Test Plan

npm test
npm start
Navigate to Settings, open the seed phrase dropdown, click the checkbox and ensure the displayed seed corresponds to the active wallet
Ensure unchecking the checkbox hides the seed phrase
Repeat the above for a freshly created wallet
Repeat the test in extension mode

Diff Detail

Repository
rABC Bitcoin ABC
Branch
seedWarning
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25514
Build 50609: Build Diffcashtab-tests
Build 50608: arc lint + arc unit

Event Timeline

emack requested review of this revision.Nov 1 2023, 06:58
bytesofman requested changes to this revision.Nov 1 2023, 12:54

We should still show the warning when the seed phrase is displayed.

Checking the checkbox should expand to reveal the seed phrase. Unchecking the checkbox should hide it.

cashtab/src/components/Configure/Configure.js
1500–1529 ↗(On Diff #42895)
This revision now requires changes to proceed.Nov 1 2023, 12:54
emack marked an inline comment as done.

Updated checkbox logic to toggle between showing and hiding the seed phrase in addition to the updated static warning message.

This revision is now accepted and ready to land.Nov 2 2023, 16:48
This revision was automatically updated to reflect the committed changes.