Page MenuHomePhabricator

[avalanche] Consolidate the proofs recent finalization state memorization
ClosedPublic

Authored by Fabien on Nov 3 2023, 11:02.

Details

Summary

D14704 fixed a bug regarding the recently finalized proofs status that could be lost under some circumstances. This diff is a follow up that applies the same logic consistently to all the places in our codebase. Note that the places where it was not used are places where it was not needed, but it is cheap enough and it guarantees that we will not be missing some edge cases in the future.

Test Plan

With Clang and Debug:

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Nov 3 2023, 11:02
PiRK added a subscriber: PiRK.
PiRK added inline comments.
src/avalanche/processor.h
299–300 ↗(On Diff #42930)
This revision is now accepted and ready to land.Nov 3 2023, 12:26