Page MenuHomePhabricator
Differential D14732

[avalanche] Consolidate the proofs recent finalization state memorization
ClosedPublic
Actions

Authored by Fabien on Nov 3 2023, 11:02.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC55867cb13628: [avalanche] Consolidate the proofs recent finalization state memorization
Summary

D14704 fixed a bug regarding the recently finalized proofs status that could be lost under some circumstances. This diff is a follow up that applies the same logic consistently to all the places in our codebase. Note that the places where it was not used are places where it was not needed, but it is cheap enough and it guarantees that we will not be missing some edge cases in the future.

Test Plan

With Clang and Debug:

ninja all check-all

Diff Detail

Event Timeline

Fabien created this revision.Nov 3 2023, 11:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 3 2023, 11:02
Fabien requested review of this revision.Nov 3 2023, 11:02
Harbormaster completed remote builds in B25525: Diff 42930.Nov 3 2023, 11:21
PiRK accepted this revision.Nov 3 2023, 12:26
PiRK added a subscriber: PiRK.
PiRK added inline comments.
src/avalanche/processor.h
299–300
This revision is now accepted and ready to land.Nov 3 2023, 12:26
Closed by commit rABC55867cb13628: [avalanche] Consolidate the proofs recent finalization state memorization (authored by Fabien). · Explain WhyNov 3 2023, 13:42
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC55867cb13628: [avalanche] Consolidate the proofs recent finalization state memorization.

Revision Contents
Changeset List

PathSize
src/
avalanche/
6 lines
33 lines
test/
89 lines
12 lines

Diff 42930

View Options

src/avalanche/processor.h

Loading...
View Options

src/avalanche/processor.cpp

Loading...
View Options

src/avalanche/test/processor_tests.cpp

Loading...
View Options

src/net_processing.cpp

Loading...