Page MenuHomePhabricator
Differential D14734

[avalanche] Move the invalid proofs filter to the peer manager
ClosedPublic
Actions

Authored by Fabien on Nov 3 2023, 16:14.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC6c7f9e00cae7: [avalanche] Move the invalid proofs filter to the peer manager
Summary

This is actually a global in net_processing, move it to the peer manager where it belongs and gives accessors.
This will make it possible to declare a proof invalid from a RPC (future diff).

There is no change of behavior.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 3 2023, 16:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 3 2023, 16:14
Fabien requested review of this revision.Nov 3 2023, 16:14
PiRK accepted this revision.EditedNov 3 2023, 16:25
PiRK added a subscriber: PiRK.

nice wrapping, one less mutex and one less global

This revision is now accepted and ready to land.Nov 3 2023, 16:25
Harbormaster completed remote builds in B25528: Diff 42940.Nov 3 2023, 16:32
Closed by commit rABC6c7f9e00cae7: [avalanche] Move the invalid proofs filter to the peer manager (authored by Fabien). · Explain WhyNov 6 2023, 08:17
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC6c7f9e00cae7: [avalanche] Move the invalid proofs filter to the peer manager.

Revision Contents
Changeset List

PathSize
src/
avalanche/
17 lines
7 lines
48 lines

Diff 42951

View Options

src/avalanche/peermanager.h

Loading...
View Options

src/avalanche/peermanager.cpp

Loading...
View Options

src/net_processing.cpp

Loading...