Page MenuHomePhabricator
Differential D14735

[Cashtab] Create targetOutput for a Cashtab Msg tx
ClosedPublic
Actions

Authored by bytesofman on Nov 3 2023, 17:59.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC1ed79850fc70: [Cashtab] Create targetOutput for a Cashtab Msg tx
Summary

To support refactor of tx creation and broadcasting functions using ecash-coinselect, create a new opreturn folder initialized with function to create desired targetOutput for a Cashtab Msg tx

Existing opreturn output generation is part of overloaded tx creation functions. Each opreturn type should have its own function.

This diff does not implement the function or change any app functionality of Cashtab.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Nov 3 2023, 17:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 3 2023, 17:59
bytesofman requested review of this revision.Nov 3 2023, 17:59
bytesofman updated this revision to Diff 42944.

remove debug logging and unused const

Harbormaster completed remote builds in B25529: Diff 42943.Nov 3 2023, 18:02
Harbormaster completed remote builds in B25530: Diff 42944.
PiRK accepted this revision.Nov 3 2023, 19:12
This revision is now accepted and ready to land.Nov 3 2023, 19:12
Closed by commit rABC1ed79850fc70: [Cashtab] Create targetOutput for a Cashtab Msg tx (authored by bytesofman). · Explain WhyNov 3 2023, 19:46
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC1ed79850fc70: [Cashtab] Create targetOutput for a Cashtab Msg tx.

Revision Contents
Changeset List

PathSize
cashtab/
src/
opreturn/
__tests__/
32 lines
fixtures/
51 lines
46 lines

Diff 42946

View Options

cashtab/src/opreturn/__tests__/index.test.js

Loading...
View Options

cashtab/src/opreturn/fixtures/vectors.js

Loading...
View Options

cashtab/src/opreturn/index.js

Loading...