Per title.
Note: this function is not currently implemented in the app.
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABC7e6681f098c7: [Cashtab] Add function to generate an OP_RETURN output for an airdrop tx
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- airdrop-msgs-helpers
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 25540 Build 50661: Build Diff cashtab-tests Build 50660: arc lint + arc unit
Event Timeline
| cashtab/src/opreturn/index.js | ||
|---|---|---|
| 15 ↗ | (On Diff #42947) | this could be done in a separate diff....done here as this is the first diff where adding this function means we don't have to repeat this comment describing specific library behavior of utxolib's op_return parsing, trivial change, and covered by existing unit tests |
| cashtab/src/opreturn/fixtures/vectors.js | ||
|---|---|---|
| 62 ↗ | (On Diff #42947) | Airdrop messages can include emojis and non-english characters as per current OP_RETURN messaging designs, so will need to include these in test vectors.  |
| cashtab/src/opreturn/index.js | ||
| 68 ↗ | (On Diff #42947) | isValidTokenId() already checks for tokenId being a non-string so no need to revalidate it again here |
| 82 ↗ | (On Diff #42947) | Should check for bunch of spaces which we don't want to take up script space. Current sendXec() logic ignores them for OP_RETURN generation. |
Comment Actions
Add unit test for non-standard utf8 characters, remove double validation check for tokenId as string, check for multiple blank spaces and add unit test for this case