[electrum] tests: raise on RPC error with proper error message
ClosedPublic
Actions

Authored by PiRK on Nov 6 2023, 15:27.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC0a6c34edfd3e: [electrum] tests: raise on RPC error with proper error message

Summary

This makes it easier to diagnose RPC errors.
Without raising on timeout error, poll_for_answer would just continue execution, now it will fail the test if a response is not received.

Also run the electrum-abc process in verbose mode for additional debugging info on stdout, and add an additional debugging/error message if the result == PACKAGE_VERSION assertion fails (which misteriously happens occasionnaly on our CI infra)

This is a partial backport of electroncash#2721
https://github.com/Electron-Cash/Electron-Cash/pull/2721/commits/0a1f39897d24092604092f48d182c50979e53e0c

Depends on D14742

Test Plan

pytest electrum/electrumabc/tests/regtest

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 6 2023, 15:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 6 2023, 15:27

PiRK requested review of this revision.Nov 6 2023, 15:27

teamcity edited the summary of this revision. (Show Details)Nov 6 2023, 15:27

Harbormaster completed remote builds in B25542: Diff 42960.Nov 6 2023, 15:29

PiRK retitled this revision from tests: raise on RPC error or timeout error with proper error message to [electrum] tests: raise on RPC error or timeout error with proper error message.Nov 6 2023, 15:31

bytesofman accepted this revision.Nov 6 2023, 22:38

This revision is now accepted and ready to land.Nov 6 2023, 22:38

PiRK retitled this revision from [electrum] tests: raise on RPC error or timeout error with proper error message to [electrum] tests: raise on RPC error with proper error message.Nov 7 2023, 06:43

Closed by commit rABC0a6c34edfd3e: [electrum] tests: raise on RPC error with proper error message (authored by EchterAgo, committed by PiRK). · Explain WhyNov 7 2023, 09:59

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC0a6c34edfd3e: [electrum] tests: raise on RPC error with proper error message.