Page MenuHomePhabricator
Differential D14763

[e.cash] Rename CustomLink to ExternalLink
ClosedPublic
Actions

Authored by Mengerian on Nov 9 2023, 19:15.

Details

Reviewers
johnkuney
Fabien
Group Reviewers
Restricted Project
Commits
rABCb342fba9440b: [e.cash] Rename CustomLink to ExternalLink
Summary

This name is a better description of what it is

Test Plan

git grep CustomLink
Run the site locally, click on various links to check that they still behave as expected

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Mengerian created this revision.Nov 9 2023, 19:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 9 2023, 19:15
Mengerian requested review of this revision.Nov 9 2023, 19:15
Harbormaster completed remote builds in B25582: Diff 43024.Nov 9 2023, 19:15
Fabien accepted this revision.Nov 10 2023, 09:20
Fabien added a subscriber: Fabien.

Thanks, much better

This revision is now accepted and ready to land.Nov 10 2023, 09:20
Closed by commit rABCb342fba9440b: [e.cash] Rename CustomLink to ExternalLink (authored by Mengerian). · Explain WhyNov 10 2023, 16:38
This revision was automatically updated to reflect the committed changes.
Mengerian added a commit: rABCb342fba9440b: [e.cash] Rename CustomLink to ExternalLink.

Revision Contents
Changeset List

PathSize
web/
e.cash/
components/
announcement-bar/
6 lines
custom-link/
external-link/
custom-link/
4 lines
footer/
10 lines
data/
42 lines
pages/
blog/
6 lines
34 lines
6 lines

Diff 43038

View Options

web/e.cash/components/announcement-bar/index.js

Loading...
View Options

web/e.cash/components/custom-link/index.js

Loading...
View Options

web/e.cash/components/external-link/index.js

Loading...
View Options

web/e.cash/components/footer/index.js

Loading...
View Options

web/e.cash/data/faqs.js

Loading...
View Options

web/e.cash/pages/blog/[slug].js

Loading...
View Options

web/e.cash/pages/mining.js

Loading...
View Options

web/e.cash/pages/wallets.js

Loading...