Differential D14776

[chronik] Remove some boilerplate from the test_framework
ClosedPublic
Actions

Authored by Fabien on Nov 13 2023, 11:24.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC6358e6d405ee: [chronik] Remove some boilerplate from the test_framework

Summary

This refactor makes the tests slightly nicer to write and read, and will allow for leveraging the timeout factor for the chronik tests in a follow up.

Test Plan

./test/functional/test_runner.py chronik_*

Diff Detail

Repository

rABC Bitcoin ABC

Branch

get_chronik_client

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25600
Build 50781: Build Diff	build-clang-tidy · build-without-wallet · build-diff · build-clang · build-debug
Build 50780: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 13 2023, 11:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 13 2023, 11:24

Fabien requested review of this revision.Nov 13 2023, 11:24

Remove change related to next diff

Fabien added a child revision: D14777: [chronik] Apply the timeout factor to the chronik connections.Nov 13 2023, 11:33

Harbormaster completed remote builds in B25600: Diff 43053.Nov 13 2023, 11:41

PiRK accepted this revision.Nov 13 2023, 11:45

This revision is now accepted and ready to land.Nov 13 2023, 11:45

Harbormaster completed remote builds in B25601: Diff 43054.Nov 13 2023, 11:57

Closed by commit rABC6358e6d405ee: [chronik] Remove some boilerplate from the test_framework (authored by Fabien). · Explain WhyNov 13 2023, 12:41

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC6358e6d405ee: [chronik] Remove some boilerplate from the test_framework.

Revision Contents
Changeset List

Path

Size

test/

functional/

chronik_avalanche.py

4 lines

chronik_block.py

6 lines

chronik_block_info.py

6 lines

chronik_block_txs.py

9 lines

chronik_blockchain_info.py

6 lines

chronik_blocks.py

6 lines

chronik_chronik_info.py

6 lines

chronik_pause.py

4 lines

chronik_raw_tx.py

6 lines

chronik_resync.py

4 lines

chronik_script_confirmed_txs.py

9 lines

chronik_script_history.py

9 lines

chronik_script_unconfirmed_txs.py

6 lines

chronik_script_utxos.py

6 lines

chronik_spent_by.py

6 lines

9 lines

6 lines

chronik_ws_script.py

6 lines

test_framework/

chronik/

2 lines

11 lines

Diff 43053

test/functional/chronik_avalanche.py

Loading...

test/functional/chronik_block.py

Loading...

test/functional/chronik_block_info.py

Loading...

test/functional/chronik_block_txs.py

Loading...

test/functional/chronik_blockchain_info.py

Loading...

test/functional/chronik_blocks.py

Loading...

test/functional/chronik_chronik_info.py

Loading...

test/functional/chronik_pause.py

Loading...

test/functional/chronik_raw_tx.py

Loading...

test/functional/chronik_resync.py

Loading...

test/functional/chronik_script_confirmed_txs.py

Loading...

test/functional/chronik_script_history.py

Loading...

test/functional/chronik_script_unconfirmed_txs.py

Loading...

test/functional/chronik_script_utxos.py

Loading...

test/functional/chronik_spent_by.py

Loading...

test/functional/chronik_tx.py

Loading...

test/functional/chronik_ws.py

Loading...

test/functional/chronik_ws_script.py

Loading...

test/functional/test_framework/chronik/client.py

Loading...

test/functional/test_framework/test_node.py

Loading...